Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat: Add user management scripts for listing users and resetting passwords #5438

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jmaddington
Copy link
Contributor

Summary

Add two scripts, one to list users and one to reset passwords

Change Type

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Testing

I ran both in my local dev environment without issue.

They are not exactly complex.

Other

I'm not sure if the updates to package.json are necessary. It seems like those should already be available based on the other scripts. But npm package management isn't my thing.

@danny-avila
Copy link
Owner

I'm not sure if the updates to package.json are necessary. It seems like those should already be available based on the other scripts. But npm package management isn't my thing.

Yes there shouldn't be any changes to package*.json files except to add the scripts, please remove those changes

@jmaddington
Copy link
Contributor Author

Done

@danny-avila
Copy link
Owner

you need to remove the changes to package-lock.json

@danny-avila
Copy link
Owner

danny-avila commented Jan 25, 2025

one way to do this, on your PR branch:

git reset HEAD~2

this will bring you back to the HEAD but still show all your changes for committing.

Then discard the package-lock file changes, followed by re-committing.

Then you must push your branch to remote with -f force flag as the git history was reset.

For testing, you should run npm run reinstall to confirm everything is working right. At the current state of the branch, npm run reinstall should fail due to the package-lock changes (and if it doesn't, it might introduce weird side effects)

@danny-avila
Copy link
Owner

You can also git revert for the same effect except not resetting the history

@jmaddington jmaddington force-pushed the new/feat/newuserscripts branch from 0cb5122 to ed57bb4 Compare January 25, 2025 15:17
@jmaddington jmaddington reopened this Jan 25, 2025
@jmaddington
Copy link
Contributor Author

Thanks for your help and patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants