Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat: Add Google Parameters, Ollama/Openrouter Reasoning, & UI Optimizations #5456

Merged
merged 8 commits into from
Jan 24, 2025

Conversation

danny-avila
Copy link
Owner

@danny-avila danny-avila commented Jan 24, 2025

Summary

  • Replaced ::: directive tags with a more XML-like syntax in both the frontend and the OpenAI client, conforming to Ollama format
    • they are then replaced to required ::: directive format in the frontend
  • Moved google model parameters to the SidePanel
  • Improved dynamic input parsing to correctly handle numeric values
  • Prevented the Thinking component from rendering null children
  • Virtualized the combobox for large data sets to enhance performance
    • This was causing significant slowdowns during streaming when using an endpoint with many models, such as Openrouter
  • Simplified various components by removing unused contexts and clarifying plugin configurations

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Testing

I ran local unit tests to ensure the new google model parameters function correctly. I also tested the updated Markdown and dynamic numeric input changes in a development environment to confirm that the replacement renders properly and numeric inputs preserve their intended values. Additionally, I suggest verifying with a wide range of model/agent lists to confirm combobox virtualization performance.

Checklist

  • My code adheres to this project's style guidelines
  • I have performed a self-review of my own code
  • I have commented in any complex areas of my code
  • I have made pertinent documentation changes
  • My changes do not introduce new warnings
  • I have written tests demonstrating that my changes are effective
  • Local unit tests pass with my changes
  • Any changes dependent on mine have been merged and published in downstream modules.

@danny-avila danny-avila merged commit af430e4 into main Jan 24, 2025
4 checks passed
@danny-avila danny-avila deleted the refactor/google-params branch January 24, 2025 23:15
@danny-avila danny-avila mentioned this pull request Jan 24, 2025
10 tasks
justinmdickey pushed a commit to e-gineering/LibreChat that referenced this pull request Jan 30, 2025
…mizations (danny-avila#5456)

* feat: Google Model Parameters

* fix: dynamic input number value, previously coerced by zod schema

* refactor: support openrouter reasoning tokens and XML for thinking directive to conform to ollama

* fix: virtualize combobox to prevent performance drop on re-renders of long model/agent/assistant lists

* refactor: simplify Fork component by removing unnecessary chat context index

* fix: prevent rendering of Thinking component when children are null

* refactor: update Markdown component to replace <think> tags and simplify remarkPlugins configuration

* refactor: reorder remarkPlugins to improve plugin configuration in Markdown component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant