-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dataplane-flowstat-plugin #1
base: main
Are you sure you want to change the base?
Conversation
3932b83
to
3e35f78
Compare
These together form the full feature: |
Signed-off-by: Dung Man <[email protected]>
3e35f78
to
8c79b00
Compare
I believe there's a license incompatibility here. flowstat.h is being licensed under Apache 2.0, which has patent clauses. This would be an additional restriction over the LGPL 2.1 licensed code being used in flowstat.c. In general, my suggestion would be to stick to the assortment of licenses that were being used in the seed code. Those are GPL 2.0, LGPL 2.1, MPL 2.0, and BSD 3-clause (for YANG). We probably need to post a page on the wiki outlining what guidelines we used when selecting licenses for pieces of code. I know that this conflicts with what @nickbroon said in danos/vyatta-dataplane#8, but I think this is better advice in general due to the incompatibility of Apache 2.0 with the majority of the rest of the DANOS code. In this particular case, I believe the best option would be to relicense everything in this repo to LGPL 2.1. Another possible option would be to use a license of Apache-2.0 OR LGPL-2.1-only, although before taking that as advice, I'd want others to weigh in on if that would work or not. I'm also not sure as to the advantages of doing that, as if Apache 2.0 was selected because of the patent provisions, an OR would allow anyone to choose to take the code under LGPL 2.1 instead and not have those patent provisions apply. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
License incompatibility needs to be resolved.
Completely agree, the licenses need to be compatible with each other. So as mention flowstat.c including flowstat.h cannot use lgpl and apache2 as they are incompatible. |
A plugin for dataplane allow viewing flow statistics.
License: some files were modified from DANOS which licensed by LGPL/GPL/BSD, others file was licensed by Apache 2.0. For more detail see debian/copyright for list files.