Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update [email protected] #224

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Update [email protected] #224

wants to merge 9 commits into from

Conversation

daohoangson
Copy link
Owner

@daohoangson daohoangson commented Sep 13, 2023

As of 0.13.1-alpha.1, broken stuff includes:

  • TextBit.insertBefore and BuildTree.detach for the smilieOp
  • buildGestureDetector third parameter was a function but it is a GestureRecognizer now
  • WidgetPlaceholder constructor had type argument but it doesn't now, the first positional param has gone away too
Screenshot 2023-10-13 at 00 33 23

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Attention: Patch coverage is 86.56716% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 35.10%. Comparing base (eb5953b) to head (227d0a9).

Files Patch % Lines
lib/src/widgets/html/galleria.dart 72.72% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #224      +/-   ##
==========================================
+ Coverage   35.02%   35.10%   +0.07%     
==========================================
  Files          97       97              
  Lines        4994     5000       +6     
==========================================
+ Hits         1749     1755       +6     
  Misses       3245     3245              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@daohoangson
Copy link
Owner Author

Going from 0.13 alpha to 0.14 stable requires additional changes:

  • BuildOp.v1 is no longer available
  • WidgetPlaceholder.firstChild is no longer available

Repository owner deleted a comment from github-actions bot Mar 25, 2024
Repository owner deleted a comment from github-actions bot Mar 25, 2024
Repository owner deleted a comment from github-actions bot Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant