Merge pull request BabylonJS#11291 from BlakeOne/master

Fix copying snippet id to clipboard for Chrome
daoshengmu · Oct 18, 2021 · ac9dcc3 · ac9dcc3
2 parents 71c5678 + 36d4d94
commit ac9dcc3
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/dist/preview release/what's new.md b/dist/preview release/what's new.md
@@ -136,6 +136,7 @@
 
 ### GUI
 
+- Allow Chrome to copy the GUI snippet id to the clipboard ([BlakeOne](https://github.com/BlakeOne))
 - Added a `FocusableButton` gui control to simplify creating menus with keyboard navigation ([Flux159](https://github.com/Flux159))
 - Added `focus()` and `blur()` functions for controls that implement `IFocusableControl` ([Flux159](https://github.com/Flux159))
 - Added `ToggleButton` GUI control ([kintz09](https://github.com/kintz09))

diff --git a/guiEditor/src/components/propertyTab/propertyTabComponent.tsx b/guiEditor/src/components/propertyTab/propertyTabComponent.tsx
@@ -221,10 +221,16 @@ export class PropertyTabComponent extends React.Component<IPropertyTabComponentP
         const savePromise = this.props.globalState.customSave?.action || this.saveToSnippetServerHelper;
         savePromise(content, adt).then((snippetId: string) => {
             adt.snippetId = snippetId;
-            if (navigator.clipboard) {
-                navigator.clipboard.writeText(adt.snippetId);
-            }
-            alert("GUI saved with ID: " + adt.snippetId + " (please note that the id was also saved to your clipboard)");
+            const alertMessage = `GUI saved with ID:  ${adt.snippetId}`;
+            if (navigator.clipboard) {                
+                navigator.clipboard.writeText(adt.snippetId).then(() => {
+                    alert(`${alertMessage}. The ID was copied to your clipboard.`);
+                }).catch((err: any) => {
+                    alert(alertMessage);
+                })
+            } else {
+                alert(alertMessage);
+            }   
             this.props.globalState.onBuiltObservable.notifyObservers();
         }).catch((err: any) => {
             alert(err);