Skip to content

Commit

Permalink
Thanks Gary
Browse files Browse the repository at this point in the history
  • Loading branch information
sebavan committed Oct 27, 2021
1 parent e37b811 commit b2721bc
Showing 1 changed file with 4 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -44,23 +44,20 @@ export class KHR_materials_emissive_strength implements IGLTFLoaderExtension {
/** @hidden */
public loadMaterialPropertiesAsync(context: string, material: IMaterial, babylonMaterial: Material): Nullable<Promise<void>> {
return GLTFLoader.LoadExtensionAsync<IKHRMaterialsEmissiveStrength>(context, material, this.name, (extensionContext, extension) => {
const promises = new Array<Promise<any>>();
promises.push(this._loader.loadMaterialPropertiesAsync(context, material, babylonMaterial));
promises.push(this._loadEmissivePropertiesAsync(extensionContext, extension, babylonMaterial));
return Promise.all(promises).then(() => { });
return this._loader.loadMaterialPropertiesAsync(context, material, babylonMaterial).then(() => {
this._loadEmissiveProperties(extensionContext, extension, babylonMaterial);
});
});
}

private _loadEmissivePropertiesAsync(context: string, properties: IKHRMaterialsEmissiveStrength, babylonMaterial: Material): Promise<void> {
private _loadEmissiveProperties(context: string, properties: IKHRMaterialsEmissiveStrength, babylonMaterial: Material): void {
if (!(babylonMaterial instanceof PBRMaterial)) {
throw new Error(`${context}: Material type not supported`);
}

if (properties.emissiveStrength !== undefined) {
babylonMaterial.emissiveColor.scaleToRef(properties.emissiveStrength, babylonMaterial.emissiveColor);
}

return Promise.resolve();
}
}

Expand Down

0 comments on commit b2721bc

Please sign in to comment.