Init EVM bridging project #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deewai
reviewed
Feb 5, 2025
| address owner = msg.sender; | ||
| string memory name = "Bidged NBA TopShot Moments"; | ||
| string memory symbol = "TOPSHOT"; | ||
| string memory cadenceNFTAddress = "cadenceNFTAddress"; |
There was a problem hiding this comment.
do we get to change these values when deploying the bridge contract?
There was a problem hiding this comment.
Right, we should specify the proper values to be used when deploying. Also, only symbol currently has admin update method - we could add more if needed via contract update later, though I don't think we're expecting any of these to change
judezhu
reviewed
Feb 7, 2025
| - [OpenZeppelin Doc - Foundry Upgrades](https://docs.openzeppelin.com/upgrades-plugins/foundry-upgrades) | ||
| - [OpenZeppelin Doc - ERC721 Contracts v5](https://docs.openzeppelin.com/contracts/5.x/api/token/erc721) | ||
| - [GitHub - OpenZeppelin Upgradeable Contracts](https://github.com/OpenZeppelin/openzeppelin-contracts-upgradeable) | ||
| - [GitHub - LimitBreak Creator Token Standards](https://github.com/limitbreakinc/creator-token-standards) |
| import {ICrossVM} from "./interfaces/ICrossVM.sol"; | ||
|
|
||
| // Initial draft version of the BridgedTopShotMoments contract | ||
| contract BridgedTopShotMoments is |
There was a problem hiding this comment.
should we not implement the upgradable interfaces or we just leave this for now util get back from opensea?
There was a problem hiding this comment.
you mean for creator token/royalties? planning to add these in follow-up changes - changed the base for this PR to a new evm-bridging branch
judezhu
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
BridgedTopShotMomentserc721 contract:Reuses erc721 template contract from FlowEVM bridge adapted to allow for upgradeability using UUPS proxy pattern from OpenZeppelin library
Additional functionality such as royalties enforcement and redemption mechanism will be addressed in follow-up changes