-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dorcyweb master #74
Open
myshit0628
wants to merge
56
commits into
window-by-title
Choose a base branch
from
master
base: window-by-title
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Dorcyweb master #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use latest version of darcy-web
Implement FindsByTitle in WebDriverParentContext
Implement FindsByUrl
Ensure browsers close in Browser factory tests, fixes #52
…t for a closer fit to the method it is testing
Screenshot API implementations
Conflicts: src/main/java/com/redhat/darcy/webdriver/WebDriverBrowser.java
Update implementations for screenshot API OutputStream updates
…ersion Conflicts: pom.xml
Use newest selenium: 2.48.2
Use selenium-server 2.50.0
Removes deprecated sonatype parent, reorganizes, and allows release to central with mvn release plugin.
Use selenium-server 2.52.0
…ix-1 Prefer isEmpty to size==0; extra null check; prefer <> operator
Use selenium 2.53.1
SessionNotFoundexception was previously depricated and then removed in Selenium 3.0.0
It should technically be backwards compatibile if your automation project only references darcy apis. But if you were still referencing selenium-rc, that's going to break.
Use selenium 3.4.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the frame