This repository has been archived by the owner on Dec 28, 2022. It is now read-only.
fix: replace document.body.scrollTo method
#20
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per [bug1724243](https://bugzilla.mozilla.org/show_bug.cgi?id=1724243) images are now rendered in a "standards-mode" instead of "quirks-mode" which makes `document.body.scrollTo` method not work with how image is displayed according to CSS rules (i.e. document's box model height is 0px).
This was referenced Nov 3, 2021
|
Thanks for the fix. Can I suggest that in future you don't reformat the code? It makes it much more difficult to see what actually changed, and therefore less likely your changes will be accepted. |
|
@darktrojan That was auto-format since Yes, I know I should not reformat code where it's not necessary, but the changes didn't looked that difficult and in the 'diff view' there's a 'hide whitespace' option, which minimizes edit clutter -- hence why I didn't revert it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per bug1724243 images are now rendered in a "standards-mode" instead of "quirks-mode" which makes
document.body.scrollTomethod not work with how image is displayed according to CSS rules (i.e. document's box model height is 0px).Resolves:
#18
#19