Added paragraph about SSE3 support to build-instructions.md. #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+319
to
+330
| To install [opemu-linux](https://github.com/mirh/opemu-linux) first clone the repository: | ||
| ```bash | ||
| git clone https://github.com/mirh/opemu-linux | ||
| ``` | ||
| then switch directories & compile the kernel module: | ||
| ```bash | ||
| cd opemu-linux && make | ||
| ``` | ||
| and load it: | ||
| ```bash | ||
| sudo insmod op_emu.ko | ||
| ``` |
There was a problem hiding this comment.
I have mixed feelings about including build instructions for projects that the Darling team does not manage. Ideally, you should submit a PR request to the opemu-linux to add build instructions.
With that being said, it's looks like that project is no longer in active development.
CuriousTommy
requested changes
Jun 29, 2024
| or more likely | ||
|
|
||
| ``` | ||
| user$ sudo darling shell |
There was a problem hiding this comment.
I don't like the implication of including a command like sudo darling shell in the wiki. I don't want the wiki to imply that this is an okay thing to do.
I recommend removing the user$ darling shell and user$ sudo darling shell part.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Added a small paragraph on how to fix missing SSE3 Support by installing the opemu-linux kernel module.
Why
I just want to save others from going through these two issues: darlinghq/darling#776, darlinghq/darling#882, before arriving at darlinghq/darling#1497 and figuring out the solution by @Mabbs works for them too.
Why like this
Yes build instructions might not be the perfectly correct page for this paragraph, but I didn't find any other “Known Issues Section” and the ZFS problem is also handled here, therefore I think it is not too out of place
Open questions/concerns
Only question, should I add a warning about installing some random kernel module from GitHub ?