Add minimal AnalysisDriverModel implementation
#3814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. |
davidmorgan
force-pushed
the
test-analysis-driver-model
branch
4 times, most recently
from
75be8cf to
3bc0a58
Compare
tests `BuildAssetUriResolver`. Add minimal implementation to `AnalysisDriverModel` to make the tests pass. Add TODOs where there is functionality not covered by tests that is therefore not added.
davidmorgan
force-pushed
the
test-analysis-driver-model
branch
from
3bc0a58 to
0797e9e
Compare
jensjoha
reviewed
Feb 3, 2025
jensjoha
reviewed
Feb 3, 2025
jensjoha
reviewed
Feb 3, 2025
jensjoha
approved these changes
Feb 3, 2025
jakemac53
approved these changes
Feb 3, 2025
| final nextId = nextIds.removeFirst(); | ||
|
|
||
| // Skip if already seen. | ||
| if (!result.add(nextId)) continue; |
There was a problem hiding this comment.
Can we avoid putting these in the queue in the first place instead? There could be a lot of duplicates otherwise.
| if (!result.add(nextId)) continue; | ||
|
|
||
| // Skip if not readable. | ||
| if (!await reader.canRead(nextId)) continue; |
There was a problem hiding this comment.
Might be worth leaving a comment that this does add the dependency on nextId just from checking for its existence
davidmorgan
commented
Feb 4, 2025
| final nextId = nextIds.removeFirst(); | ||
|
|
||
| // Skip if already seen. | ||
| if (!result.add(nextId)) continue; |
| if (!result.add(nextId)) continue; | ||
|
|
||
| // Skip if not readable. | ||
| if (!await reader.canRead(nextId)) continue; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #3811, review and merge #3813 first.
Make
resolver_test.darttestAnalysisDriverModelexactly like it testsBuildAssetUriResolver.Add minimal implementation to
AnalysisDriverModelto make the tests pass.Add TODOs where there is functionality not covered by tests that is therefore not added.
This implementation does work for real builds, a local edit to point
BuildAssetUriResolver.sharedtoAnalysisDriverModelis enough to make the benchmarks run. Because there is no caching in the new implementation at all, it's slower :) which gives us a good starting point to add caching.