Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2976. Add non-ambiguity tests #3034

Merged
merged 2 commits into from
Jan 10, 2025
Merged

#2976. Add non-ambiguity tests #3034

merged 2 commits into from
Jan 10, 2025

Conversation

sgrekhov
Copy link
Contributor

@sgrekhov sgrekhov commented Jan 3, 2025

eernstg
eernstg reviewed Jan 9, 2025
View reviewed changes
Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, with a few comments!

I'm worried about tests with multiple syntax errors, but I think we can avoid splitting it into 117 tests and still be rather safe.

LanguageFeatures/Static-access-shorthand/non_ambiguity_A01_t02.dart Outdated Show resolved Hide resolved
LanguageFeatures/Static-access-shorthand/non_ambiguity_A02_t01.dart Outdated Show resolved Hide resolved
LanguageFeatures/Static-access-shorthand/non_ambiguity_A02_t01.dart Outdated Show resolved Hide resolved
LanguageFeatures/Static-access-shorthand/non_ambiguity_A02_t01.dart Show resolved Hide resolved
LanguageFeatures/Static-access-shorthand/non_ambiguity_A02_t02.dart Show resolved Hide resolved
LanguageFeatures/Static-access-shorthand/non_ambiguity_A02_t02.dart Show resolved Hide resolved
LanguageFeatures/Static-access-shorthand/non_ambiguity_A02_t03.dart Outdated Show resolved Hide resolved
LanguageFeatures/Static-access-shorthand/non_ambiguity_A02_t04.dart Outdated Show resolved Hide resolved
sgrekhov
sgrekhov commented Jan 10, 2025
View reviewed changes
Copy link
Contributor Author

@sgrekhov sgrekhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. PTAL

LanguageFeatures/Static-access-shorthand/non_ambiguity_A01_t02.dart Outdated Show resolved Hide resolved
LanguageFeatures/Static-access-shorthand/non_ambiguity_A02_t01.dart Outdated Show resolved Hide resolved
LanguageFeatures/Static-access-shorthand/non_ambiguity_A02_t01.dart Show resolved Hide resolved
LanguageFeatures/Static-access-shorthand/non_ambiguity_A02_t02.dart Show resolved Hide resolved
LanguageFeatures/Static-access-shorthand/non_ambiguity_A02_t02.dart Show resolved Hide resolved
LanguageFeatures/Static-access-shorthand/non_ambiguity_A02_t04.dart Outdated Show resolved Hide resolved
@sgrekhov sgrekhov requested a review from eernstg January 10, 2025 08:30
eernstg
eernstg approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

LanguageFeatures/Static-access-shorthand/non_ambiguity_A02_t02.dart Show resolved Hide resolved
@eernstg eernstg merged commit f535969 into dart-lang:master Jan 10, 2025
1 of 2 checks passed
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Jan 17, 2025
@sgrekhov
[co19] Roll co19 to e1fd1cf868e6fb778c426058737ad0c02122df33
b93c826 
2025-01-17 [email protected] Fixes dart-lang/co19#3044. Update expected errors positions for CFE (dart-lang/co19#3046)
2025-01-15 [email protected] dart-lang/co19#2976. Add more tests for records, factories and parenthesized expressions (dart-lang/co19#3047)
2025-01-15 [email protected] dart-lang/co19#2119. Actualize nnbd/static_errors_A12* description (dart-lang/co19#3048)
2025-01-14 [email protected] Fixes dart-lang/co19#3029. Add more tests for constants (dart-lang/co19#3045)
2025-01-14 [email protected] dart-lang/co19#2976. Add patterns tests (dart-lang/co19#3031)
2025-01-13 [email protected] dart-lang/co19#2976. Add more operators tests (dart-lang/co19#3043)
2025-01-13 [email protected] dart-lang/co19#3030. Add tests constants tests for String.length (dart-lang/co19#3041)
2025-01-13 [email protected] Fixes dart-lang/co19#3038. Read link to finalized object to avoid early finalization (dart-lang/co19#3042)
2025-01-10 [email protected] dart-lang/co19#2976. Add non-ambiguity tests (dart-lang/co19#3034)
2025-01-10 [email protected] dart-lang/co19#2976. Add more grammar tests (dart-lang/co19#3035)

Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try
Change-Id: I9feb50a33b33e85dc017d0d47829502d4f631ac7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/405001
Reviewed-by: Alexander Thomas <[email protected]>
Reviewed-by: Erik Ernst <[email protected]>
Commit-Queue: Erik Ernst <[email protected]>
Commit-Queue: Alexander Thomas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eernstg eernstg eernstg approved these changes

@chloestefantsova chloestefantsova Awaiting requested review from chloestefantsova

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sgrekhov @eernstg