Update to and fix latest lints #1335
Conversation
|
|
||
| analyzer: | ||
| errors: | ||
| comment_references: ignore |
| include: package:lints/recommended.yaml | ||
| linter: | ||
| rules: | ||
| - avoid_dynamic_calls |
There was a problem hiding this comment.
all of these are in dart_flutter_team_lints
| @@ -312,7 +313,7 @@ class CommentSequence extends ListBase<SourceComment> { | |||
| SourceComment operator [](int index) => _comments[index]; | |||
|
|
|||
| @override | |||
| operator []=(int index, SourceComment value) => | |||
| void operator []=(int index, SourceComment value) => | |||
There was a problem hiding this comment.
This return type is pointless. Index setters are like setters: they can never return a value anyway.
There was a problem hiding this comment.
Generally agree, so maybe the lint needs to be updated for this case!
There was a problem hiding this comment.
I believe the lint is doing the right thing. I enabled always_declare_return_types and tested it on:
class Foo {
get getter => 1;
set setter(int value) => 1;
method() => 1;
operator [](int index) => 1;
operator []=(int index, int value) => 1;
}I get lint warnings on getter, method(), and operator [], but not setter or operator []=. Maybe the fix is out of sync with the lint? Or maybe this was just a mistake fixing the lint? Either way, I think you can delete this void and it should still be lint clean.
There was a problem hiding this comment.
This LGTM, but note that I have a very large PR out (#1336) that will probably collide with this in nasty ways and I really don't want that PR (which is blocking any other progress on the new back end) any harder to land than it already is.
Would you be OK with waiting until that's in and updating this PR with those changes first?
No description provided.