Merge branch 'more-config' of github.com:brianquinlan/http into more-…

…config
dart-lang · Dec 4, 2023 · 20baa84 · 20baa84
2 parents 1dd2fd0 + 60d062e
commit 20baa84
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/pkgs/cupertino_http/example/integration_test/url_session_configuration_test.dart b/pkgs/cupertino_http/example/integration_test/url_session_configuration_test.dart
@@ -27,7 +27,6 @@ Future<Map<String, List<String>>> sentHeaders(
       Uri(scheme: 'http', host: 'localhost', port: server.port)))
     ..resume();
   while (task.state != URLSessionTaskState.urlSessionTaskStateCompleted) {
-    // Let the event loop run.
     await pumpEventQueue();
   }
 

diff --git a/pkgs/cupertino_http/lib/src/cupertino_api.dart b/pkgs/cupertino_http/lib/src/cupertino_api.dart
@@ -350,11 +350,11 @@ class URLSessionConfiguration
   ///
   /// See [NSURLSessionConfiguration.HTTPAdditionalHeaders](https://developer.apple.com/documentation/foundation/nsurlsessionconfiguration/1411532-httpadditionalheaders)
   Map<String, String>? get httpAdditionalHeaders {
-    if (_nsObject.HTTPAdditionalHeaders == null) {
-      return null;
+    if (_nsObject.HTTPAdditionalHeaders case var additionalHeaders?) {
+      final headers = ncb.NSDictionary.castFrom(additionalHeaders);
+      return stringDictToMap(headers);
     }
-    final headers = ncb.NSDictionary.castFrom(_nsObject.HTTPAdditionalHeaders!);
-    return stringDictToMap(headers);
+    return null;
   }
 
   set httpAdditionalHeaders(Map<String, String>? headers) {