Fix incorrect documentation that used the old isOwned name (#1140)

dart-lang · Feb 29, 2024 · 37fceb8 · 37fceb8
1 parent 6e0a46f
commit 37fceb8
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/pkgs/cronet_http/CHANGELOG.md b/pkgs/cronet_http/CHANGELOG.md
@@ -1,6 +1,8 @@
 ## 1.2.0-wip
 
 * Support the Cronet embedding dependency with `--dart-define=cronetHttpNoPlay=true`.
+* Fix a bug in the documentation where `isOwned` is used rather than
+  `closeEngine`.
 
 ## 1.1.1
 

diff --git a/pkgs/cronet_http/README.md b/pkgs/cronet_http/README.md
@@ -38,11 +38,10 @@ void main() async {
   final Client httpClient;
   if (Platform.isAndroid) {
     final engine = CronetEngine.build(
-      cacheMode: CacheMode.memory,
-      cacheMaxSize: 2 * 1024 * 1024,
-      userAgent: 'Book Agent',
-    );
-    httpClient = CronetClient.fromCronetEngine(engine, isOwned: true);
+        cacheMode: CacheMode.memory,
+        cacheMaxSize: 2 * 1024 * 1024,
+        userAgent: 'Book Agent');
+    httpClient = CronetClient.fromCronetEngine(engine, closeEngine: true);
   } else {
     httpClient = IOClient(HttpClient()..userAgent = 'Book Agent');
   }