Remove invalid status line tests and replace them with valid status l…

…ine tests (#1018)
dart-lang · Sep 15, 2023 · decefa6 · decefa6
1 parent e19094a
commit decefa6
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 13 deletions.
diff --git a/pkgs/http_client_conformance_tests/lib/src/response_status_line_server.dart b/pkgs/http_client_conformance_tests/lib/src/response_status_line_server.dart
@@ -29,6 +29,7 @@ void hybridMain(StreamChannel<Object?> channel) async {
       socket.writeAll(
         [
           statusLine,
+          'Access-Control-Allow-Origin: *',
           'Content-Length: 0',
           '\r\n', // Add \r\n at the end of this header section.
         ],

diff --git a/pkgs/http_client_conformance_tests/lib/src/response_status_line_tests.dart b/pkgs/http_client_conformance_tests/lib/src/response_status_line_tests.dart
@@ -10,7 +10,10 @@ import 'package:test/test.dart';
 import 'response_status_line_server_vm.dart'
     if (dart.library.html) 'response_status_line_server_web.dart';
 
-/// Tests that the [Client] correctly processes the response status line.
+/// Tests that the [Client] correctly processes the response status line (e.g.
+/// 'HTTP/1.1 200 OK\r\n').
+///
+/// Clients behavior varies considerably if the status line is not valid.
 void testResponseStatusLine(Client client) async {
   group('response status line', () {
     late String host;
@@ -23,17 +26,20 @@ void testResponseStatusLine(Client client) async {
       host = 'localhost:${await httpServerQueue.next}';
     });
 
-    test(
-      'without status code',
-      () async {
-        httpServerChannel.sink.add('HTTP/1.1 OK');
-        await expectLater(
-          client.get(Uri.http(host, '')),
-          throwsA(isA<ClientException>()),
-        );
-      },
-      skip:
-          'Enable after https://github.com/dart-lang/http/issues/1013 is fixed',
-    );
+    test('complete', () async {
+      httpServerChannel.sink.add('HTTP/1.1 201 Created');
+      final response = await client.get(Uri.http(host, ''));
+      expect(response.statusCode, 201);
+      expect(response.reasonPhrase, 'Created');
+    });
+
+    test('no reason phrase', () async {
+      httpServerChannel.sink.add('HTTP/1.1 201');
+      final response = await client.get(Uri.http(host, ''));
+      expect(response.statusCode, 201);
+      // An empty Reason-Phrase is allowed according to RFC-2616. Any of these
+      // interpretations seem reasonable.
+      expect(response.reasonPhrase, anyOf(isNull, '', 'Created'));
+    });
   });
 }