-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add response status code test #1009
Add response status code test #1009
Conversation
pkgs/http_client_conformance_tests/lib/src/response_status_line_server.dart
Outdated
Show resolved
Hide resolved
pkgs/http_client_conformance_tests/lib/src/response_status_line_server.dart
Outdated
Show resolved
Hide resolved
pkgs/http_client_conformance_tests/lib/src/response_status_line_server.dart
Outdated
Show resolved
Hide resolved
pkgs/http_client_conformance_tests/lib/src/response_status_line_tests.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the PR message.
cronet_http fails this test - maybe mark is as skipped with a reason like 'currently failing in cronet_http, see XXX` where XXX is a link to an issue that you file against cronet_http ;-) |
Hey @brianquinlan,
This PR is now ready for review! 🎉 |
Created a new test group
response status line
to test thatpackage:http
clients correctly process the response status line.Added a new test
without status code
to theresponse status line
test group.The
without status code
test checks thatpackage:http
clients can handle an HTTP response status line with a missing status code, e.g.HTTP/1.1 OK
.cronet_http
is failingwithout status code test
, we are skipping the test until we fix this issue: cronet_http is failing "without status code" test #1013.Created a new test server
response_status_line_server.dart
that receives a status line from the client and sets this as the response status line.Contribution guidelines:
dart format
.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.