Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add response status code test #1009

Merged

Conversation

alex-james-dev
Copy link
Contributor

@alex-james-dev alex-james-dev commented Aug 21, 2023

  • Created a new test group response status line to test that package:http clients correctly process the response status line.

  • Added a new test without status code to the response status line test group.

  • The without status code test checks that package:http clients can handle an HTTP response status line with a missing status code, e.g. HTTP/1.1 OK.

  • cronet_http is failing without status code test, we are skipping the test until we fix this issue: cronet_http is failing "without status code" test #1013.

  • Created a new test server response_status_line_server.dart that receives a status line from the client and sets this as the response status line.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Copy link
Collaborator

@brianquinlan brianquinlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the PR message.

@brianquinlan
Copy link
Collaborator

cronet_http fails this test - maybe mark is as skipped with a reason like 'currently failing in cronet_http, see XXX` where XXX is a link to an issue that you file against cronet_http ;-)

@alex-james-dev
Copy link
Contributor Author

alex-james-dev commented Aug 25, 2023

Hey @brianquinlan,

  • The PR message has been updated.

  • An issue has been filed against cronet_http because it fails the without status code test in the response status line test group: cronet_http is failing "without status code" test #1013.

  • Until we fix this issue, we will skip the without status code test and output the following message instead:

Enable after https://github.com/dart-lang/sdk/issues/ is fixed

This PR is now ready for review! 🎉

@alex-james-dev alex-james-dev marked this pull request as ready for review August 25, 2023 23:47
@brianquinlan brianquinlan merged commit cad7d60 into dart-lang:master Aug 26, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants