pkgs/ok_http: Stream response bodies. #1233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camsim99
reviewed
Jun 13, 2024
There was a problem hiding this comment.
At a high level, this looks great and is what I envisioned when we talked! I'll defer to @brianquinlan for a final review :)
pkgs/ok_http/android/src/main/kotlin/com/example/ok_http/AsyncInputStreamReader.kt
Outdated
Show resolved
Hide resolved
brianquinlan
approved these changes
Jun 13, 2024
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
Jun 14, 2024
Revisions updated by `dart tools/rev_sdk_deps.dart`. collection (https://github.com/dart-lang/collection/compare/c90b19f..9354f38): 9354f38 2024-06-13 Kevin Moore Require Dart 3.4, test wasm on 3.4, prepare release (dart-lang/collection#349) http (https://github.com/dart-lang/http/compare/e2e2170..8c325b9): 8c325b9 2024-06-14 Anikate De pkgs/ok_http: Stream response bodies. (dart-lang/http#1233) http_parser (https://github.com/dart-lang/http_parser/compare/53d4041..71b4c2c): 71b4c2c 2024-06-13 Graciliano Monteiro Passos `CaseInsensitiveMap`: added constructor `fromEntries`. (dart-lang/http_parser#99) Change-Id: I0f848975241261f42e0759d00188fef12731a085 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/371740 Auto-Submit: Devon Carew <[email protected]> Reviewed-by: Konstantin Shcheglov <[email protected]> Reviewed-by: Kevin Moore <[email protected]> Commit-Queue: Konstantin Shcheglov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Items in this PR:
AsyncInputStreamReaderthat provides a function to asynchronously read ajava.io.InputStreamusingExecutorService, and generate bindingsDataCallbackinterface and add the required logic to stream response bodiestestAllThis PR marks 100% conformance of
package:ok_httpwith HTTP standards! 🎉Contribution guidelines:
dart format.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.