Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a workflow for publishing flutter packages #1286

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

natebosch
Copy link
Member

Closes #1259

Add a second copy of the publish workflow with use-flutter: true.
Add ignore-packages to both workflows to ignore published packages for
the non-relevant SDK.

Closes #1259

Add a second copy of the publish workflow with `use-flutter: true`.
Add `ignore-packages` to both workflows to ignore published packages for
the non-relevant SDK.
@github-actions github-actions bot added the type-infra A repository infrastructure change or enhancement label Aug 6, 2024
It looked like it was specified as a string, so I assumed we should use
the comma separated format as if it were passed as a CLI arg, but that
doesn't seem to have any effect.
Github actions don't support yaml lists?
Does the comment show up on the PR?
@@ -12,6 +12,8 @@ jobs:
publish:
if: ${{ github.repository_owner == 'dart-lang' }}
uses: dart-lang/ecosystem/.github/workflows/publish.yaml@main
with:
ignore-packages: pkgs/cupertino_http,pkgs/cronet_http,pkgs/ok_http
permissions:
id-token: write # Required for authentication using OIDC
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@devoncarew - Are these config lines stale? I don't see the same in the other repos I checked.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

github-actions bot commented Aug 6, 2024

Package publishing

Package Version Status Publish tag (post-merge)
package:http 1.2.3 ready to publish http-v1.2.3
package:http_profile 0.1.0 already published at pub.dev
package:web_socket 0.1.6 already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

if: ${{ github.repository_owner == 'dart-lang' }}
uses: dart-lang/ecosystem/.github/workflows/publish.yaml@main
with:
use-flutter: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like something we should auto-detect, right? Maybe?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It did initially, and then that functionality was removed.
dart-lang/ecosystem#158

I'm not sure I understand the "We need the flag anyhow to decide whether to setup Flutter in the first place" statement. @mosuem do you recall what this meant?

Copy link
Member

@mosuem mosuem Aug 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It means that instead of setting up dart via setup-dart, we would use the setup-flutter action. To auto-detect, we would to implement that before running the dart setup, so in a bash script in the github workflow itself (or a dart script, by running an additional setup- step before).

@brianquinlan
Copy link
Collaborator

Is this ready to land?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-infra A repository infrastructure change or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initial publish of ok_http and firehose setup
4 participants