-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Http-parser: Make CaseInsensitiveMap be extension type. #1716
base: master
Are you sure you want to change the base?
Conversation
Avoids extending a class unnecessarily, which *may* pave the way for `package:collection` making the class final.
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. Coverage ✔️
This check for test coverage is informational (issues shown here will not fail the PR). API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
License Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's neat! My first introduction to extension types.
Hold a sec. Strictly, this is breaking right? Folks might implement/extend this? Maybe we say that's okay, but we should at least discuss. |
Good point! @lrhn said that this type is not publicly visible but it seems to be The only instances of |
Avoids extending a class unnecessarily, which may pave the way for
package:collection
making the class final.(Nothing uses that
CaseInsensitiveMap
is a type at all, the constructors could all just be functions returningMap
.)Change is not breaking, the type is not publicly visible.