Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename runProc -> runConstrained and move related classes into src/tool/run_constrained #1302

Merged
merged 2 commits into from
Dec 21, 2023
Merged

Rename runProc -> runConstrained and move related classes into src/tool/run_constrained #1302

merged 2 commits into from
Dec 21, 2023

Conversation

isoos
Copy link
Collaborator

@isoos isoos commented Dec 20, 2023

  • This PR does not change the code.
  • Further refactor/breaking changes will touch this code, and it become way too many things changing at once - I'm splitting up the PRs, and this is the first part.

@isoos isoos requested review from jonasfj and sigurdm December 20, 2023 15:25
sigurdm
sigurdm approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@sigurdm sigurdm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but lets also rename the function to runProcess (or something even better... runWithTimeout...) Doesn't have to be this PR, but maybe the file-name should be changed already now.

runProc doesn't really say much, and is an abbreviation.

@isoos
Copy link
Collaborator Author

isoos commented Dec 21, 2023

Renamed to runWithTimeout (also run_with_timeout.dart).

@isoos isoos changed the title Move runProc + related classes into src/tool/run_proc.dart. Rename runProc -> runWithTimeout and move related classes into src/tool/run_with_timeout Dec 21, 2023
@isoos isoos changed the title Rename runProc -> runWithTimeout and move related classes into src/tool/run_with_timeout Rename runProc -> runConstrained and move related classes into src/tool/run_constrained Dec 21, 2023
@isoos
Copy link
Collaborator Author

isoos commented Dec 21, 2023

after an offline discussion, renamed to runConstrained.

@isoos isoos merged commit 6811de8 into dart-lang:master Dec 21, 2023
5 checks passed
@isoos isoos deleted the runproc branch December 21, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sigurdm sigurdm sigurdm approved these changes

@jonasfj jonasfj Awaiting requested review from jonasfj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isoos @sigurdm