Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deploy.yml workflow file #5450

Closed
khanhnwin opened this issue Jan 4, 2024 · 1 comment · Fixed by #5473
Closed

Remove deploy.yml workflow file #5450

khanhnwin opened this issue Jan 4, 2024 · 1 comment · Fixed by #5473
Assignees
@khanhnwin
Labels
e0-minutes Can complete in < 60 minutes of normal, not dedicated, work from.team Reported by Dash docs team member infra.structure Relates to the tools that create dart.dev p3-low Valid but not urgent concern. Resolve when possible. Encourage upvote to surface. st.blocked Issue cannot continue until another action completes

Comments

@khanhnwin
Copy link
Contributor

Describe the problem

As discussed with @parlough in #5449 - we're keeping deploy.yml in place for now so that other teams migrating from GitHub Actions --> Cloud Build for Firebase deploys have an example to reference. However, once that's done we should delete deploy.yml.

Expected fix

File is deleted from the site-www repo.

On which platform(s) did you experience this issue?

No response

Additional context

No response
@khanhnwin khanhnwin added infra.structure Relates to the tools that create dart.dev from.user Issue raised by user labels Jan 4, 2024
@khanhnwin khanhnwin self-assigned this Jan 4, 2024
@khanhnwin
Copy link
Contributor Author

cc @parlough @drewroengoogle

@parlough parlough added p3-low Valid but not urgent concern. Resolve when possible. Encourage upvote to surface. st.blocked Issue cannot continue until another action completes e0-minutes Can complete in < 60 minutes of normal, not dedicated, work from.team Reported by Dash docs team member and removed from.user Issue raised by user labels Jan 4, 2024
@parlough parlough mentioned this issue Jan 18, 2024
Merged
khanhnwin pushed a commit that referenced this issue Jan 18, 2024
@parlough
Remove now unused deploy.yml file from repo (#5473)
5b632a7 
@khanhnwin Do you mind if I remove this? It's been a bit confusing as
I'm migrating various related pieces. We can always link to the relevant
migration PRs for anyone that would like them as a reference.

Closes #5450
atsansone pushed a commit to atsansone/site-www that referenced this issue Jan 26, 2024
@parlough @atsansone
Remove now unused deploy.yml file from repo (dart-lang#5473)
522a43e 
@khanhnwin Do you mind if I remove this? It's been a bit confusing as
I'm migrating various related pieces. We can always link to the relevant
migration PRs for anyone that would like them as a reference.

Closes dart-lang#5450
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@khanhnwin khanhnwin

Labels
e0-minutes Can complete in < 60 minutes of normal, not dedicated, work from.team Reported by Dash docs team member infra.structure Relates to the tools that create dart.dev p3-low Valid but not urgent concern. Resolve when possible. Encourage upvote to surface. st.blocked Issue cannot continue until another action completes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove now unused deploy.yml file from repo dart-lang/site-www
2 participants
@khanhnwin @parlough