Minor fixes and cleanup for security advisories page #5485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MaryaBelanger Thanks for reviewing and landing the original PR!! I didn't take a look until after it landed, but found a few minor issues and areas of improvements. I tried to outline the changes I made in the PR description to outline some of things I'm looking for when reviewing changes like this. Maybe it'll be helpful? Either way, let me know if you have any questions. Thanks again :) |
|
Visit the preview URL for this PR (updated for commit 88c0ea3): https://dart-dev--pr5485-fix-cleanup-security-advisories-page-m0c8oobj.web.app |
MaryaBelanger
approved these changes
Jan 24, 2024
atsansone
pushed a commit
to atsansone/site-www
that referenced
this pull request
Jan 26, 2024
Follow-up to dart-lang#5480 Fixes dart-lang#5458 A few things: - Adjusts the placeholder redirect to point to the new page - Add a cross-link from the pubspec reference page - Fixes a few typos - Use descriptive link text instead of "Here" - Remove `/en` from the GitHub link, so it's more likely redirect to the desired language of the user - In the "Ignoring security advisories" section, if putting the pubspec field `ignored_advisories` in code font, it's not really "a list of `ignored_advisories`, but rather a list itself. - Uses proper capitalization for "GitHub" - Use "the Dart team" instead of "we" for the recommendation - Some other minor wording adjustments _(please take a look :])_
atsansone
pushed a commit
to atsansone/site-www
that referenced
this pull request
Feb 20, 2024
Follow-up to dart-lang#5480 Fixes dart-lang#5458 A few things: - Adjusts the placeholder redirect to point to the new page - Add a cross-link from the pubspec reference page - Fixes a few typos - Use descriptive link text instead of "Here" - Remove `/en` from the GitHub link, so it's more likely redirect to the desired language of the user - In the "Ignoring security advisories" section, if putting the pubspec field `ignored_advisories` in code font, it's not really "a list of `ignored_advisories`, but rather a list itself. - Uses proper capitalization for "GitHub" - Use "the Dart team" instead of "we" for the recommendation - Some other minor wording adjustments _(please take a look :])_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #5480
Fixes #5458
A few things:
/enfrom the GitHub link, so it's more likely redirect to the desired language of the userignored_advisoriesin code font, it's not really "a list ofignored_advisories, but rather a list itself.