Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove legacy Sipi upload mechanism (DEV-4260) #3414

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

siers
Copy link
Contributor

@siers siers commented Nov 4, 2024

Pull Request Checklist

Task Description/Number

Issue Number: DEV-

PR Type

  • build/chore: maintenance tasks (no production code change)
  • docs: documentation changes (no production code change)
  • feat: represents new features
  • fix: represents bug fixes
  • perf: performance improvements
  • refactor: represents production code refactoring
  • test: adding or refactoring tests (no production code change)
  • deprecated: Deprecation warning (ideally referencing a migration guide)

Basic requirements for bug fixes and features

  • Tests for the changes have been added
  • Docs have been added / updated

Does this PR introduce a breaking change?

  • Yes

Copy link

linear bot commented Nov 4, 2024

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 17.88%. Comparing base (6ebe8e7) to head (f10a5d1).
Report is 127 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #3414       +/-   ##
===========================================
- Coverage   83.04%   17.88%   -65.16%     
===========================================
  Files         290      304       +14     
  Lines       23087    22760      -327     
===========================================
- Hits        19172     4071    -15101     
- Misses       3915    18689    +14774     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@siers siers force-pushed the fix/DEV-4260-remove-sipi-upload branch 2 times, most recently from f10a5d1 to 119bfdd Compare November 12, 2024 10:26
@siers siers force-pushed the fix/DEV-4260-remove-sipi-upload branch from 576d34c to 9503eb9 Compare November 12, 2024 13:36
@siers siers force-pushed the fix/DEV-4260-remove-sipi-upload branch 2 times, most recently from 559609b to 95afa29 Compare November 14, 2024 14:47
@siers siers force-pushed the fix/DEV-4260-remove-sipi-upload branch from 95afa29 to 929949f Compare November 15, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant