-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove legacy Sipi upload mechanism (DEV-4260) #3414
Open
siers
wants to merge
10
commits into
main
Choose a base branch
from
fix/DEV-4260-remove-sipi-upload
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siers
requested review from
BalduinLandolt,
mpro7 and
seakayone
as code owners
November 4, 2024 13:13
siers
force-pushed
the
fix/DEV-4260-remove-sipi-upload
branch
from
November 7, 2024 14:20
7fe1865
to
ae1eddd
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3414 +/- ##
===========================================
- Coverage 83.04% 17.88% -65.16%
===========================================
Files 290 304 +14
Lines 23087 22760 -327
===========================================
- Hits 19172 4071 -15101
- Misses 3915 18689 +14774 ☔ View full report in Codecov by Sentry. |
siers
force-pushed
the
fix/DEV-4260-remove-sipi-upload
branch
2 times, most recently
from
November 12, 2024 10:26
f10a5d1
to
119bfdd
Compare
siers
force-pushed
the
fix/DEV-4260-remove-sipi-upload
branch
from
November 12, 2024 13:36
576d34c
to
9503eb9
Compare
siers
force-pushed
the
fix/DEV-4260-remove-sipi-upload
branch
2 times, most recently
from
November 14, 2024 14:47
559609b
to
95afa29
Compare
siers
force-pushed
the
fix/DEV-4260-remove-sipi-upload
branch
from
November 15, 2024 11:06
95afa29
to
929949f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Task Description/Number
Issue Number: DEV-
PR Type
Basic requirements for bug fixes and features
Does this PR introduce a breaking change?