refactor: use stillimagefilevaluehasexternalurl (DEV-4109) (#648)

* refactor: use stillImageFileValueHasExternalUrl instead of fileValueHasExternalUrl * chore: mark as deprecated
dasch-swiss · Sep 30, 2024 · b589688 · b589688
1 parent ab59ad8
commit b589688
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 4 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@dasch-swiss/dsp-js",
-  "version": "10.2.1",
+  "version": "10.2.2",
   "description": "JavaScript library that handles API requests to Knora",
   "main": "index.js",
   "files": [

diff --git a/src/models/v2/Constants.ts b/src/models/v2/Constants.ts
@@ -129,6 +129,9 @@ export class Constants {
     static StillImageFileValueHasDimX = Constants.KnoraApiV2 + Constants.HashDelimiter + "stillImageFileValueHasDimX";
     static StillImageFileValueHasDimY = Constants.KnoraApiV2 + Constants.HashDelimiter + "stillImageFileValueHasDimY";
     static StillImageFileValueHasIIIFBaseUrl = Constants.KnoraApiV2 + Constants.HashDelimiter + "stillImageFileValueHasIIIFBaseUrl";
+    /**
+     * @deprecated FileValueHasExternalUrl will be removed in future versions. Use StillImageFileValueHasExternalUrl instead.
+     */
     static FileValueHasExternalUrl = Constants.KnoraApiV2 + Constants.HashDelimiter + "fileValueHasExternalUrl";
     static StillImageFileValueHasExternalUrl = Constants.KnoraApiV2 + Constants.HashDelimiter + "stillImageFileValueHasExternalUrl";
     static AudioFileValueHasDuration = Constants.KnoraApiV2 + Constants.HashDelimiter + "audioFileValueHasDuration";

diff --git a/src/models/v2/resources/values/create/create-file-value.ts b/src/models/v2/resources/values/create/create-file-value.ts
@@ -66,7 +66,7 @@ export class CreateStillImageFileValue extends CreateFileValue {
  */
 @JsonObject("CreateStillImageExternalFileValue")
 export class CreateStillImageExternalFileValue extends CreateFileValue {
-    @JsonProperty(Constants.FileValueHasExternalUrl, String, true)
+    @JsonProperty(Constants.StillImageFileValueHasExternalUrl, String, true)
     externalUrl?: string = "";
     constructor() {
         super(Constants.StillImageExternalFileValue);

diff --git a/src/models/v2/resources/values/update/update-file-value.ts b/src/models/v2/resources/values/update/update-file-value.ts
@@ -67,7 +67,7 @@ export class UpdateStillImageFileValue extends UpdateFileValue {
  */
 @JsonObject("UpdateStillImageExternalFileValue")
 export class UpdateExternalStillImageFileValue extends UpdateFileValue {
-    @JsonProperty(Constants.FileValueHasExternalUrl, String, true)
+    @JsonProperty(Constants.StillImageFileValueHasExternalUrl, String, true)
     externalUrl: string;
     constructor() {
         super(Constants.StillImageExternalFileValue);

diff --git a/vars.mk b/vars.mk
@@ -6,4 +6,4 @@ else
 endif
 
 API_REPO := dasch-swiss/dsp-api
-API_VERSION := v30.18.2
+API_VERSION := v30.18.4