Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve error handling #48

Merged
merged 5 commits into from
Oct 15, 2023
Merged

chore: improve error handling #48

merged 5 commits into from
Oct 15, 2023

Conversation

jnussbaum
Copy link
Collaborator

No description provided.

BalduinLandolt
BalduinLandolt approved these changes Oct 13, 2023
View reviewed changes
Copy link
Collaborator

@BalduinLandolt BalduinLandolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noted some thoughts on the __str__ thing, but nothing of huge gravity. Otherwise looks good

dsp_permissions_scripts/models/api_error.py Show resolved Hide resolved
@jnussbaum jnussbaum merged commit 8a436cc into main Oct 15, 2023
1 check passed
@jnussbaum jnussbaum deleted the wip/improve-error-handling branch October 15, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BalduinLandolt BalduinLandolt BalduinLandolt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jnussbaum @BalduinLandolt