Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: simplify and restructure unit tests #94

Merged
merged 6 commits into from
Apr 19, 2024
Merged

test: simplify and restructure unit tests #94

merged 6 commits into from
Apr 19, 2024

Conversation

jnussbaum
Copy link
Collaborator

No description provided.

@jnussbaum jnussbaum self-assigned this Apr 17, 2024
@jnussbaum jnussbaum changed the title test: write more unit tests test: write more unit tests (DEV-3511) Apr 18, 2024
@linear Linear
Copy link

linear bot commented Apr 18, 2024

DEV-3511 permissions-scripts: add missing unit tests

  • add tests for PermissionScope.from_dict() und .get()
  • prevent creating an empty PermissionScope()
  • test custom groups
  • compare_scopes might be useless, scopes can be compared straightforward with assert scope1==scope2

@jnussbaum jnussbaum changed the title test: write more unit tests (DEV-3511) test: simplify and restructure unit tests (DEV-3511) Apr 19, 2024
@jnussbaum jnussbaum changed the title test: simplify and restructure unit tests (DEV-3511) test: simplify and restructure unit tests Apr 19, 2024
@jnussbaum jnussbaum merged commit 7358037 into main Apr 19, 2024
1 check passed
@jnussbaum jnussbaum deleted the wip/write-more-unittests branch April 19, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jnussbaum jnussbaum

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jnussbaum