Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(validate-data): validate MovingImageRepresentation (DEV-4333) #1268

Open
wants to merge 29 commits into
base: main
Choose a base branch
from

Conversation

Nora-Olivia-Ammann
Copy link
Collaborator

No description provided.

@Nora-Olivia-Ammann Nora-Olivia-Ammann self-assigned this Nov 12, 2024
Copy link

linear bot commented Nov 12, 2024

@@ -358,9 +358,9 @@ def _reformat_one_validation_result(validation_result: ValidationResult) -> Inpu

def _reformat_min_cardinality_validation_result(validation_result: ResultMinCardinalityViolation) -> InputProblem:
iris = _reformat_main_iris(validation_result)
file_value_properties = ["shapes:hasGenericFileValue"]
file_value_properties = ["hasMovingImageFileValue"]
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As in the previous PR I want to change the identification, I will likely move it up to the query section. But that touches a lot of other code that has nothing to do with this, so I would like to do that separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant