refactor(xmlupload): serialise values in classes #1272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nora-Olivia-Ammann
changed the title
jnussbaum
reviewed
Nov 14, 2024
src/dsp_tools/commands/xmlupload/models/serialise/serialise_value.py
Outdated
Show resolved
Hide resolved
…lue.py Co-authored-by: Johannes Nussbaum <[email protected]>
…://github.com/dasch-swiss/dsp-tools into wip/refactor-xmlupload-serialise-string-value
jnussbaum
reviewed
Nov 14, 2024
jnussbaum
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
While I would prefer to first resolve https://github.com/dasch-swiss/dsp-tools/pull/1272/files#r1842550019, I also don't want to block you from moving forward. If you prefer tackling this in a follow-up PR, feel free to merge.
I would prefer to make it in a clean up PR. Then I don't have to do too many things at once. Thanks |
Nora-Olivia-Ammann
deleted the
wip/refactor-xmlupload-serialise-string-value
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.