-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Boost dash::sort with even more parallelism #611
Open
rkowalewski
wants to merge
99
commits into
development
Choose a base branch
from
feat-sort-high-parallelism
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #611 +/- ##
===============================================
- Coverage 84.95% 84.57% -0.39%
===============================================
Files 335 344 +9
Lines 24821 25028 +207
Branches 11497 11285 -212
===============================================
+ Hits 21087 21167 +80
- Misses 3733 3851 +118
- Partials 1 10 +9
|
When the input- and out buffer are not the same, we can use a series of non inplace buffers.
This reverts commit 9d082a6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need more parallelism to exploit the power of many-core nodes. The underlying algorithm itself will be rewritten to eliminate barriers. This includes the following major changes:
Algorithmic improvements:
alltoall
communications)dash::sort(first, last, out, sort_hash)
.Minor changes
DART_UNDEFINED_UNIT_ID
as a valid unit for DART communication routines DART API calls with DART_UNDEFINED_UNIT_ID #617Further Impacts
Note: This list will grow.