Allow for multiple Team splits and team cloning #663
Conversation
Codecov Report
@@ Coverage Diff @@
## development #663 +/- ##
===============================================
+ Coverage 85.1% 85.17% +0.06%
===============================================
Files 336 336
Lines 24927 24993 +66
Branches 11766 11824 +58
===============================================
+ Hits 21215 21288 +73
- Misses 3689 3690 +1
+ Partials 23 15 -8
|
|
As you disable all of the traversial API, than why do we have this |
|
Good question. It doesn't seem to be used anywhere in the examples or applications and I don't see an immediate use-case to iterate over levels in the |
|
There is one reason though, the deconstructor, which also removes all children. I'm fine with this as is. |
| @@ -611,7 +672,8 @@ class Team | |||
| mutable team_unit_t _myid = UNDEFINED_TEAM_UNIT_ID; | |||
| mutable size_t _size = 0; | |||
| Team * _parent = nullptr; | |||
| Team * _child = nullptr; | |||
| std::vector<Team*> _children; | |||
| std::mutex _mutex; | |||
There was a problem hiding this comment.
It should be mutable once we have const Teams :D
There was a problem hiding this comment.
I only referenced the _mutex (see the M&M rule here). Also, I think that this and the _children would be a prerequisite for having const Teams in the future.
Make the team hierarchy a tree and allow for cloning teams, which is useful in multi-threaded environments.
Fixes #658