Skip to content

Commit

Permalink
test(e2e): fix test case for updating the collector configuration
Browse files Browse the repository at this point in the history
This test broke in commit 6b4da30,
when the export in the monitoring resource for e2e test was changed from
an http exporter to a dash0 exporter.
  • Loading branch information
basti1302 committed Sep 26, 2024
1 parent ad1ab66 commit e3f0460
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
2 changes: 1 addition & 1 deletion test/e2e/dash0_monitoring_resource.go
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ func updateEndpointOfDash0MonitoringResource(
) {
updateDash0MonitoringResource(
namespace,
fmt.Sprintf("{\"spec\":{\"export\":{\"http\":{\"endpoint\":\"%s\"}}}}", newEndpoint),
fmt.Sprintf("{\"spec\":{\"export\":{\"dash0\":{\"endpoint\":\"%s\"}}}}", newEndpoint),
)
}

Expand Down
7 changes: 4 additions & 3 deletions test/e2e/e2e_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -747,9 +747,10 @@ var _ = Describe("Dash0 Kubernetes Operator", Ordered, func() {
By("updating the Dash0 monitoring resource endpoint setting")
newEndpoint := "ingress.us-east-2.aws.dash0-dev.com:4317"
updateEndpointOfDash0MonitoringResource(applicationUnderTestNamespace, newEndpoint)
// Note: updating the endpoint in this way will lead to telemetry from the applications under test no longer
// being sent to otlp-sink. This is not relevant for this test case, but might be an issue if we ever add
// more tests to this suite after this one.
defer func() {
// reset the endpoint to the default after this test
updateEndpointOfDash0MonitoringResource(applicationUnderTestNamespace, defaultEndpoint)
}()

By("waiting for self-monitoring metrics")
Eventually(func(g Gomega) {
Expand Down

0 comments on commit e3f0460

Please sign in to comment.