Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backendconnection): add annotation to prevent ArgoCD pruning #157

Merged

Commits on Sep 26, 2024

  1. fix(backendconnection): add annotation to prevent ArgoCD pruning

    For clusters managed by ArgoCD, we need to prevent ArgoCD to prune
    Kubernetes resources necessary for the OTel collector managed by the
    operator. If pruning is enabled in ArgoCD, it will automatically delete
    resources which have no owner reference. This applies to all
    cluster-scoped resources which the operator creates (since
    cluster-scoped resource cannot be owned by namespace-scoped resources).
    
    In particular, this affects the cluster role & cluster role binding.
    
    References:
    * argoproj/argo-cd#4764 (comment)
      this indicates that only top level resources are pruned (which is
      basically the same as resources without an owner reference).
    * The docs for preventing this on a resource level are here:
      https://argo-cd.readthedocs.io/en/stable/user-guide/sync-options/#no-prune-resources
    basti1302 committed Sep 26, 2024
    Configuration menu
    Copy the full SHA
    9eda835 View commit details
    Browse the repository at this point in the history