Skip to content

Commit

Permalink
temporary changes for testing the container image push
Browse files Browse the repository at this point in the history
  • Loading branch information
basti1302 committed Jan 30, 2024
1 parent 9da96a4 commit b60d4c9
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 4 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/build-images.yml
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ jobs:
fi
- name: Configure AWS credentials
if: inputs.push == 'true'
# if: inputs.push
uses: aws-actions/configure-aws-credentials@v4
with:
aws-access-key-id: ${{secrets.DEPLOYMENT_WRITE_ECR_ACCESS_KEY}}
Expand All @@ -135,7 +135,7 @@ jobs:

- name: Login to Amazon ECR
id: login-ecr
if: inputs.push == 'true'
# if: inputs.push == 'true'
uses: aws-actions/amazon-ecr-login@v2
with:
mask-password: true
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -84,3 +84,4 @@ jobs:
with:
push: false
version: 'dev'
secrets: inherit

Check failure on line 87 in .github/workflows/checks.yml

View workflow job for this annotation

GitHub Actions / yamllint

87:21 [new-line-at-end-of-file] no new line character at the end of file
6 changes: 4 additions & 2 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,12 @@ on:
release:
types: [published]

workflow_dispatch:

jobs:
build_and_push_images:
uses: ./.github/workflows/build-images.yml
with:
push: true
version: ${{ github.event.release.tag_name }}
secrets: inherit
version: 0.0.1
secrets: inherit

Check failure on line 17 in .github/workflows/release.yml

View workflow job for this annotation

GitHub Actions / yamllint

17:21 [new-line-at-end-of-file] no new line character at the end of file

0 comments on commit b60d4c9

Please sign in to comment.