Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fixes #35] Changing <All Time> label and hint #36

Merged
merged 1 commit into from
Oct 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/broadway_dashboard.ex
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ defmodule BroadwayDashboard do
<:col>
<.row>
<:col>
<.card title="All time" hint="Messages since start." inner_title="successful"><%= @stats.successful %></.card>
<.card title="Successful" hint="Messages since the BroadwayDashboard page was first mounted." inner_title="successful"><%= @stats.successful %></.card>
</:col>
<:col>
<.card inner_title="failed"><%= @stats.failed %></.card>
Expand Down
4 changes: 2 additions & 2 deletions test/broadway_dashboard_test.exs
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ defmodule BroadwayDashboardTest do
rendered = render(live)
assert rendered =~ "Updates automatically"
assert rendered =~ "Throughput"
assert rendered =~ "All time"
assert rendered =~ "Successful"
end

test "auto discover is enabled when pipeline is registered using via" do
Expand Down Expand Up @@ -131,7 +131,7 @@ defmodule BroadwayDashboardTest do
rendered = render(live)
assert rendered =~ "Updates automatically"
assert rendered =~ "Throughput"
assert rendered =~ "All time"
assert rendered =~ "Successful"

assert rendered =~ "prod_0"

Expand Down