Skip to content
This repository has been archived by the owner on Dec 16, 2021. It is now read-only.

Commit

Permalink
feat: change an order of error check to provide better and faster deb…
Browse files Browse the repository at this point in the history 
…ug info (#129)
  • Loading branch information
@antouhou
antouhou authored Jun 3, 2021
1 parent 59a5293 commit 2035226
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 14 deletions.
10 changes: 5 additions & 5 deletions test/e2e/dpns.spec.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,8 @@ describe('DPNS', () => {
}

expect(broadcastError).to.exist();
expect(broadcastError.code).to.equal(2);
expect(broadcastError.message).to.be.equal('Invalid state transition: DataTriggerConditionError: Action is not allowed');
expect(broadcastError.code).to.equal(2);
expect(broadcastError.data.errors[0].name).to.equal('DataTriggerConditionError');
expect(broadcastError.data.errors[0].message).to.equal('Action is not allowed');
});
Expand All @@ -108,8 +108,8 @@ describe('DPNS', () => {
}

expect(broadcastError).to.exist();
expect(broadcastError.code).to.equal(2);
expect(broadcastError.message).to.be.equal('Invalid state transition: DataTriggerConditionError: Action is not allowed');
expect(broadcastError.code).to.equal(2);
expect(broadcastError.data.errors[0].name).to.equal('DataTriggerConditionError');
expect(broadcastError.data.errors[0].message).to.equal('Action is not allowed');
});
Expand All @@ -136,8 +136,8 @@ describe('DPNS', () => {
}

expect(broadcastError).to.exist();
expect(broadcastError.code).to.equal(2);
expect(broadcastError.message).to.be.equal('Invalid state transition: DataTriggerConditionError: Can\'t create top level domain for this identity');
expect(broadcastError.code).to.equal(2);
expect(broadcastError.data.errors[0].name).to.equal('DataTriggerConditionError');
expect(broadcastError.data.errors[0].message).to.equal('Can\'t create top level domain for this identity');
});
Expand Down Expand Up @@ -215,8 +215,8 @@ describe('DPNS', () => {
}

expect(broadcastError).to.exist();
expect(broadcastError.code).to.equal(2);
expect(broadcastError.message).to.be.equal('Invalid state transition: DataTriggerConditionError: Action is not allowed');
expect(broadcastError.code).to.equal(2);
expect(broadcastError.data.errors[0].name).to.equal('DataTriggerConditionError');
expect(broadcastError.data.errors[0].message).to.equal('Action is not allowed');
});
Expand All @@ -233,8 +233,8 @@ describe('DPNS', () => {
}

expect(broadcastError).to.exist();
expect(broadcastError.code).to.equal(2);
expect(broadcastError.message).to.be.equal('Invalid state transition: DataTriggerConditionError: Action is not allowed');
expect(broadcastError.code).to.equal(2);
expect(broadcastError.data.errors[0].name).to.equal('DataTriggerConditionError');
expect(broadcastError.data.errors[0].message).to.equal('Action is not allowed');
});
Expand Down
6 changes: 3 additions & 3 deletions test/functional/platform/Document.spec.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,8 @@ describe('Platform', () => {
}

expect(broadcastError).to.exist();
expect(broadcastError.code).to.be.equal(3);
expect(broadcastError.message).to.be.equal('State Transition is invalid: InvalidDocumentTypeError: Contract doesn\'t contain type undefinedType');
expect(broadcastError.code).to.be.equal(3);
const [error] = broadcastError.data.errors;
expect(error.name).to.equal('InvalidDocumentTypeError');
});
Expand Down Expand Up @@ -153,8 +153,8 @@ describe('Platform', () => {
}

expect(broadcastError).to.exist();
expect(broadcastError.code).to.be.equal(2);
expect(broadcastError.message).to.be.equal('Invalid state transition: DuplicateDocumentError: Duplicate Document found');
expect(broadcastError.code).to.be.equal(2);

const [error] = broadcastError.data.errors;
expect(error.name).to.equal('DuplicateDocumentError');
Expand Down Expand Up @@ -287,8 +287,8 @@ describe('Platform', () => {
}

expect(broadcastError).to.exist();
expect(broadcastError.code).to.be.equal(2);
expect(broadcastError.message).to.be.equal('Invalid state transition: DocumentTimestampWindowViolationError: Document createdAt timestamp are out of block time window and 2 more');
expect(broadcastError.code).to.be.equal(2);

const [error] = broadcastError.data.errors;
expect(error.name).to.equal('DocumentTimestampWindowViolationError');
Expand Down
12 changes: 6 additions & 6 deletions test/functional/platform/Identity.spec.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,8 @@ describe('Platform', () => {
}

expect(broadcastError).to.exist();
expect(broadcastError.code).to.be.equal(3);
expect(broadcastError.message).to.be.equal('State Transition is invalid: InvalidIdentityAssetLockProofSignatureError: Invalid Asset lock proof signature');
expect(broadcastError.code).to.be.equal(3);
const [error] = broadcastError.data.errors;
expect(error.name).to.equal('InvalidIdentityAssetLockProofSignatureError');
});
Expand Down Expand Up @@ -132,8 +132,8 @@ describe('Platform', () => {
}

expect(broadcastError).to.exist();
expect(broadcastError.code).to.be.equal(3);
expect(broadcastError.message).to.be.equal('State Transition is invalid: IdentityAssetLockTransactionOutPointAlreadyExistsError: Asset lock transaction outPoint already exists');
expect(broadcastError.code).to.be.equal(3);
const [error] = broadcastError.data.errors;
expect(error.name).to.equal('IdentityAssetLockTransactionOutPointAlreadyExistsError');
});
Expand Down Expand Up @@ -175,8 +175,8 @@ describe('Platform', () => {

expect(broadcastError).to.exist();

expect(broadcastError.code).to.be.equal(2);
expect(broadcastError.message).to.be.equal('Invalid state transition: IdentityPublicKeyAlreadyExistsError: Identity public key already exists');
expect(broadcastError.code).to.be.equal(2);
const [error] = broadcastError.data.errors;
expect(error.name).to.equal('IdentityPublicKeyAlreadyExistsError');
expect(Buffer.from(error.publicKeyHash)).to.deep.equal(identity.getPublicKeyById(0).hash());
Expand Down Expand Up @@ -352,8 +352,8 @@ describe('Platform', () => {
}

expect(broadcastError).to.exist();
expect(broadcastError.code).to.be.equal(9);
expect(broadcastError.message).to.be.equal('Failed precondition: Not enough credits');
expect(broadcastError.code).to.be.equal(9);
});

it.skip('should fail top-up if instant lock is not valid', async () => {
Expand Down Expand Up @@ -391,8 +391,8 @@ describe('Platform', () => {
}

expect(broadcastError).to.exist();
expect(broadcastError.code).to.be.equal(3);
expect(broadcastError.message).to.be.equal('State Transition is invalid: InvalidIdentityAssetLockProofSignatureError: Invalid Asset lock proof signature');
expect(broadcastError.code).to.be.equal(3);
const [error] = broadcastError.data.errors;
expect(error.name).to.equal('IdentityAssetLockTransactionNotFoundError');
});
Expand Down Expand Up @@ -473,8 +473,8 @@ describe('Platform', () => {
}

expect(broadcastError).to.exist();
expect(broadcastError.code).to.be.equal(3);
expect(broadcastError.message).to.be.equal('State Transition is invalid: IdentityAssetLockTransactionOutPointAlreadyExistsError: Asset lock transaction outPoint already exists');
expect(broadcastError.code).to.be.equal(3);
const [error] = broadcastError.data.errors;
expect(error.name).to.equal('IdentityAssetLockTransactionOutPointAlreadyExistsError');
});
Expand Down

0 comments on commit 2035226

Please sign in to comment.