Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Topper integration #599

Merged
merged 5 commits into from
Sep 12, 2023
Merged

feat: Topper integration #599

merged 5 commits into from
Sep 12, 2023

Conversation

Syn-McJ
Copy link
Member

@Syn-McJ Syn-McJ commented Sep 11, 2023

Issue being fixed or feature implemented

Topper widget integration

What was done?

  • Topper entry point
  • Topper widget (launched in a SFSafariViewController)
  • Reading keys and ids from Topper-Info.plist

How Has This Been Tested?

QA

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@Syn-McJ Syn-McJ self-assigned this Sep 11, 2023
@Syn-McJ Syn-McJ merged commit 14874b8 into dashpay:develop Sep 12, 2023
1 check passed
@pankcuf pankcuf mentioned this pull request Oct 2, 2023
Merged
5 tasks
@Syn-McJ Syn-McJ deleted the feature/topper branch October 21, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pankcuf pankcuf pankcuf approved these changes

Assignees

@Syn-McJ Syn-McJ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Syn-McJ @pankcuf