Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: PIN dialog being cut-off #610

Merged
merged 1 commit into from
Oct 16, 2023
Merged

fix: PIN dialog being cut-off #610

merged 1 commit into from
Oct 16, 2023

Conversation

Syn-McJ
Copy link
Member

@Syn-McJ Syn-McJ commented Oct 13, 2023

Showing the PIN dialog in the .pageSheet context (iOS 15+) causes the PIN dialog to be cut-off at the edge of the sheet.

What was done?

  • Dismiss confirmation dialogs before requesting PIN.

How Has This Been Tested?

QA

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@Syn-McJ Syn-McJ requested a review from pankcuf October 13, 2023 14:18
@Syn-McJ Syn-McJ self-assigned this Oct 13, 2023
@Syn-McJ Syn-McJ merged commit 09ed3b5 into dashpay:develop Oct 16, 2023
1 check passed
@Syn-McJ Syn-McJ deleted the fix/pin-dialog-cutoff branch October 21, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pankcuf pankcuf pankcuf approved these changes

Assignees

@Syn-McJ Syn-McJ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Syn-McJ @pankcuf