Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(crowdnode): improve withdrawal precision #614

Merged
merged 5 commits into from
Oct 31, 2023
Merged

feat(crowdnode): improve withdrawal precision #614

merged 5 commits into from
Oct 31, 2023

Conversation

Syn-McJ
Copy link
Member

@Syn-McJ Syn-McJ commented Oct 31, 2023

Issue being fixed or feature implemented

We want to replace blockchain API with web API to increase the precision of withdrawal requests.

What was done?

  • Add withdrawal message type to the web API
  • Replace the blockchain withdrawal command with sending the withdrawal message
  • Remove the confirmation dialog that calculates the actual amount for the blockchain API

How Has This Been Tested?

QA

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@Syn-McJ Syn-McJ requested a review from pankcuf October 31, 2023 07:41
@Syn-McJ Syn-McJ self-assigned this Oct 31, 2023
pankcuf
pankcuf approved these changes Oct 31, 2023
View reviewed changes
Copy link
Collaborator

@pankcuf pankcuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Syn-McJ Syn-McJ merged commit 90c15ae into dashpay:develop Oct 31, 2023
1 check passed
@Syn-McJ Syn-McJ deleted the feature/crowdnode-withdrawal-precision branch October 31, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pankcuf pankcuf pankcuf approved these changes

Assignees

@Syn-McJ Syn-McJ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Syn-McJ @pankcuf