Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change rate "syncing" label #649

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Conversation

Syn-McJ
Copy link
Member

@Syn-McJ Syn-McJ commented Apr 23, 2024

Issue being fixed or feature implemented

While rates are fetching, the fiat value says "syncing" which is confusing for users who are thinking the chain is syncing.

What was done?

Replace "syncing" with "fetching rates"

How Has This Been Tested?

QA

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@Syn-McJ Syn-McJ requested a review from pankcuf April 23, 2024 14:08
@Syn-McJ Syn-McJ self-assigned this Apr 23, 2024
Copy link
Collaborator

@pankcuf pankcuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Syn-McJ Syn-McJ merged commit f1378e2 into dashpay:develop Apr 25, 2024
1 check passed
@Syn-McJ Syn-McJ deleted the fix/rate-syncing branch April 25, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants