Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(coinjoin): network switching #667

Merged
merged 4 commits into from
Oct 3, 2024
Merged

feat(coinjoin): network switching #667

merged 4 commits into from
Oct 3, 2024

Conversation

Syn-McJ
Copy link
Member

@Syn-McJ Syn-McJ commented Oct 3, 2024

Issue being fixed or feature implemented

Network switching should work properly for CoinJoin.

What was done?

  • When the network switches, stop CoinJoin and replace CoinJoinManager instance that is being used.
  • Recheck working chain on every state update in case the event didn't fire.
  • Save CoinJoin mode separately for mainnet and testnet.

How Has This Been Tested?

QA

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@Syn-McJ Syn-McJ requested a review from pankcuf October 3, 2024 04:43
@Syn-McJ Syn-McJ self-assigned this Oct 3, 2024
pankcuf
pankcuf approved these changes Oct 3, 2024
View reviewed changes
Copy link
Collaborator

@pankcuf pankcuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Syn-McJ Syn-McJ merged commit 75d0c86 into dashpay:feat/coinjoin Oct 3, 2024
1 check passed
@Syn-McJ Syn-McJ deleted the feat/coinjoin-network-switch branch October 3, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pankcuf pankcuf pankcuf approved these changes

Assignees

@Syn-McJ Syn-McJ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Syn-McJ @pankcuf