Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(coinjoin): timeskew detection & dialog #668

Merged
merged 9 commits into from
Oct 7, 2024
Merged

feat(coinjoin): timeskew detection & dialog #668

merged 9 commits into from
Oct 7, 2024

Conversation

Syn-McJ
Copy link
Member

@Syn-McJ Syn-McJ commented Oct 7, 2024

Issue being fixed or feature implemented

  • If the user has the wrong device time set, we must inform them and prevent CoinJoin from starting.
  • signAndPublishTransaction logic works incorrectly; it checks if CoinJoin is mixing to decide if it should only use mixed inputs. However, CoinJoin can be enabled but not mixing.

What was done?

  • Timeskew dialogs on launch and on the CoinJoin levels page.
  • Pass mixedOnly parameter from DWPaymentProcessor to DashSync.

DashSync: dashpay/dashsync-iOS#573

How Has This Been Tested?

QA

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@Syn-McJ Syn-McJ requested a review from pankcuf October 7, 2024 12:29
@Syn-McJ Syn-McJ self-assigned this Oct 7, 2024
pankcuf
pankcuf approved these changes Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@pankcuf pankcuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Syn-McJ Syn-McJ merged commit 58996a0 into dashpay:feat/coinjoin Oct 7, 2024
1 check passed
@Syn-McJ Syn-McJ deleted the feat/coinjoin-timeskew branch October 7, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pankcuf pankcuf pankcuf approved these changes

Assignees

@Syn-McJ Syn-McJ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Syn-McJ @pankcuf