Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(usernames): Join DashPay & voting info dialogs #671

Merged

Conversation

Syn-McJ
Copy link
Member

@Syn-McJ Syn-McJ commented Oct 23, 2024

Issue being fixed or feature implemented

We need to show info dialogs first time user opens "Join Dashpay"

What was done?

Info dialogs

How Has This Been Tested?

QA

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@Syn-McJ Syn-McJ marked this pull request as draft October 23, 2024 14:45
@Syn-McJ Syn-McJ changed the title Feat/usernames submit request UI feat(usernames): Join DashPay & voting info dialogs Oct 24, 2024
@Syn-McJ Syn-McJ requested a review from pankcuf October 24, 2024 10:04
@Syn-McJ Syn-McJ self-assigned this Oct 24, 2024
@Syn-McJ Syn-McJ marked this pull request as ready for review October 24, 2024 10:05
Copy link
Collaborator

@pankcuf pankcuf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Syn-McJ Syn-McJ merged commit b461f1b into dashpay:feat/coinjoin Nov 5, 2024
0 of 3 checks passed
@Syn-McJ Syn-McJ deleted the feat/usernames-submit-request-ui branch November 5, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants