-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add invite funding key derivation path #140
base: master
Are you sure you want to change the base?
feat: add invite funding key derivation path #140
Conversation
This should also update the DIP-9 table: https://github.com/dashpay/dips/blob/master/dip-0009/assignments.md |
Co-authored-by: thephez <[email protected]>
Co-authored-by: thephez <[email protected]>
Co-authored-by: thephez <[email protected]>
1967a27
to
1639276
Compare
@thephez I have made the requested changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also update the table of contents to include the new section? I just noticed it wasn't included there.
@thephez I finally updated the PR based on your latest comments. |
Co-authored-by: thephez <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few more minor ones 🙂
Co-authored-by: thephez <[email protected]>
Co-authored-by: thephez <[email protected]>
Co-authored-by: thephez <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me 👍
This PR will add invite funding key derivation paths to DIP13.