warning: unused `std::result::Result` that must be used --> grovedb/src/replication.rs:86:13 | 86 | / writeln!( 87 | | f, 88 | | " prefix:{:?} -> path:{:?}", 89 | | hex::encode(prefix), 90 | | metadata_path_str 91 | | ); | |_____________^ | = note: this `Result` may be an `Err` variant, which should be handled = note: `#[warn(unused_must_use)]` on by default = note: this warning originates in the macro `writeln` (in Nightly builds, run with -Z macro-backtrace for more info)

very complex type used. Consider factoring parts into `type` definitions: grovedb/src/lib.rs#L958

warning: very complex type used. Consider factoring parts into `type` definitions --> grovedb/src/lib.rs:958:10 | 958 | ) -> Result<HashMap<Vec<Vec<u8>>, (CryptoHash, CryptoHash, CryptoHash)>, Error> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity

very complex type used. Consider factoring parts into `type` definitions: grovedb/src/lib.rs#L888

warning: very complex type used. Consider factoring parts into `type` definitions --> grovedb/src/lib.rs:888:10 | 888 | ) -> Result<HashMap<Vec<Vec<u8>>, (CryptoHash, CryptoHash, CryptoHash)>, Error> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity

very complex type used. Consider factoring parts into `type` definitions: grovedb/src/lib.rs#L862

warning: very complex type used. Consider factoring parts into `type` definitions --> grovedb/src/lib.rs:862:10 | 862 | ) -> Result<HashMap<Vec<Vec<u8>>, (CryptoHash, CryptoHash, CryptoHash)>, Error> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity = note: `#[warn(clippy::type_complexity)]` on by default

length comparison to zero: grovedb/src/reference_path.rs#L222

warning: length comparison to zero --> grovedb/src/reference_path.rs:222:76 | 222 | if usize::from(no_of_elements_to_keep) > current_path.len() || current_path.len() == 0 { | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `current_path.is_empty()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero = note: `#[warn(clippy::len_zero)]` on by default

redundant closure: grovedb/src/reference_path.rs#L92

warning: redundant closure --> grovedb/src/reference_path.rs:92:14 | 92 | .map(|segment| hex::encode(segment)) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `hex::encode` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure

writing `&Vec` instead of `&[_]` involves a new object where a slice will do: grovedb/src/reference_path.rs#L90

warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do --> grovedb/src/reference_path.rs:90:23 | 90 | fn display_path(path: &Vec<Vec<u8>>) -> String { | ^^^^^^^^^^^^^ help: change this to: `&[Vec<u8>]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg

use of `or_insert_with` to construct default value: grovedb/src/query_result_type.rs#L414

warning: use of `or_insert_with` to construct default value --> grovedb/src/query_result_type.rs:414:41 | 414 | map.entry(last).or_insert_with(Vec::new).push(key); | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default

redundant pattern matching, consider using `is_some()`: grovedb/src/query_result_type.rs#L412

warning: redundant pattern matching, consider using `is_some()` --> grovedb/src/query_result_type.rs:412:24 | 412 | if let Some(_) = path.pop() { | -------^^^^^^^------------- help: try: `if path.pop().is_some()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching = note: `#[warn(clippy::redundant_pattern_matching)]` on by default

use of `or_insert_with` to construct default value: grovedb/src/query_result_type.rs#L339

warning: use of `or_insert_with` to construct default value --> grovedb/src/query_result_type.rs:339:37 | 339 | map.entry(last).or_insert_with(Vec::new).push(element); | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default

use of `or_insert_with` to construct default value: grovedb/src/query_result_type.rs#L320

warning: use of `or_insert_with` to construct default value --> grovedb/src/query_result_type.rs:320:26 | 320 | .or_insert_with(BTreeMap::new) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default

use of `or_insert_with` to construct default value: grovedb/src/query_result_type.rs#L302

warning: use of `or_insert_with` to construct default value --> grovedb/src/query_result_type.rs:302:22 | 302 | .or_insert_with(BTreeMap::new) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default

use of `or_insert_with` to construct default value: grovedb/src/query_result_type.rs#L285

warning: use of `or_insert_with` to construct default value --> grovedb/src/query_result_type.rs:285:37 | 285 | map.entry(last).or_insert_with(Vec::new).push(key); | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default = note: `#[warn(clippy::unwrap_or_default)]` on by default

unneeded `return` statement: grovedb/src/query/mod.rs#L496

warning: unneeded `return` statement --> grovedb/src/query/mod.rs:496:13 | 496 | return true; | ^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return = note: `#[warn(clippy::needless_return)]` on by default help: remove `return` | 496 - return true; 496 + true |

this expression creates a reference which is immediately dereferenced by the compiler: grovedb/src/query/mod.rs#L485

warning: this expression creates a reference which is immediately dereferenced by the compiler --> grovedb/src/query/mod.rs:485:75 | 485 | Some(path) => writeln!(f, " in_path: Some({})", hex_to_ascii(&path)), | ^^^^^ help: change this to: `path` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow = note: `#[warn(clippy::needless_borrow)]` on by default

manual implementation of `Option::map`: grovedb/src/query/mod.rs#L353

warning: manual implementation of `Option::map` --> grovedb/src/query/mod.rs:353:29 | 353 | / ... if let Some(subquery) = &query.default_subquery_branch.subquery { 354 | | ... Some(SinglePathSubquery::from_query(subquery)) 355 | | ... } else { 356 | | ... None 357 | | ... } | |_______________________^ help: try: `query.default_subquery_branch.subquery.as_ref().map(|subquery| SinglePathSubquery::from_query(subquery))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map

manual implementation of `Option::map`: grovedb/src/query/mod.rs#L302

warning: manual implementation of `Option::map` --> grovedb/src/query/mod.rs:302:41 | 302 | / ... if let Some(subquery) = &subquery_branch.subquery { 303 | | ... Some(SinglePathSubquery::from_query(subquery)) 304 | | ... } else { 305 | | ... None 306 | | ... } | |_______________________^ help: try: `subquery_branch.subquery.as_ref().map(|subquery| SinglePathSubquery::from_query(subquery))` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map = note: `#[warn(clippy::manual_map)]` on by default

the following explicit lifetimes could be elided: 'a: grovedb/src/query/mod.rs#L279

warning: the following explicit lifetimes could be elided: 'a --> grovedb/src/query/mod.rs:279:32 | 279 | pub fn query_items_at_path<'a>(&'a self, path: &[&[u8]]) -> Option<SinglePathSubquery> { | ^^ ^^ ^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes = note: `#[warn(clippy::needless_lifetimes)]` on by default help: elide the lifetimes | 279 - pub fn query_items_at_path<'a>(&'a self, path: &[&[u8]]) -> Option<SinglePathSubquery> { 279 + pub fn query_items_at_path(&self, path: &[&[u8]]) -> Option<SinglePathSubquery> { |

parameter is only used in recursion: grovedb/src/operations/proof/verify.rs#L199

warning: parameter is only used in recursion --> grovedb/src/operations/proof/verify.rs:199:9 | 199 | prove_options: &ProveOptions, | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_prove_options` | note: parameter used here --> grovedb/src/operations/proof/verify.rs:273:37 | 273 | ... prove_options, | ^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#only_used_in_recursion = note: `#[warn(clippy::only_used_in_recursion)]` on by default

called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()`: grovedb/src/operations/proof/verify.rs#L324

warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` --> grovedb/src/operations/proof/verify.rs:324:25 | 324 | limit_left.as_mut().map(|limit| *limit -= 1); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- | | | help: try: `if let Some(limit) = limit_left.as_mut() { ... }` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn

called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()`: grovedb/src/operations/proof/verify.rs#L252

warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` --> grovedb/src/operations/proof/verify.rs:252:13 | 252 | limit_left.as_mut().map(|limit| *limit -= 1); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- | | | help: try: `if let Some(limit) = limit_left.as_mut() { ... }` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn

unnecessary operation: grovedb/src/operations/proof/verify.rs#L33

warning: unnecessary operation --> grovedb/src/operations/proof/verify.rs:33:13 | 33 | / query.query.limit.ok_or(Error::NotSupported( 34 | | "limits must be set in verify_query_with_absence_proof".to_string(), 35 | | ))? as usize; | |_________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation = note: `#[warn(clippy::unnecessary_operation)]` on by default help: statement can be reduced to | 33 ~ query.query.limit.ok_or(Error::NotSupported( 34 + "limits must be set in verify_query_with_absence_proof".to_string(), 35 + ))?; |

deref which would be done by auto-deref: grovedb/src/operations/proof/util.rs#L313

warning: deref which would be done by auto-deref --> grovedb/src/operations/proof/util.rs:313:31 | 313 | .map(|e| hex_to_ascii(*e)) | ^^ help: try: `e` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref

this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice`: grovedb/src/operations/proof/util.rs#L312

warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` --> grovedb/src/operations/proof/util.rs:312:10 | 312 | path.into_iter() | ^^^^^^^^^ help: call directly: `iter` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref

this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec`: grovedb/src/operations/proof/util.rs#L305

warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` --> grovedb/src/operations/proof/util.rs:305:10 | 305 | path.into_iter() | ^^^^^^^^^ help: call directly: `iter` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref = note: `#[warn(clippy::into_iter_on_ref)]` on by default

the borrowed expression implements the required traits: grovedb/src/operations/proof/util.rs#L300

warning: the borrowed expression implements the required traits --> grovedb/src/operations/proof/util.rs:300:37 | 300 | format!("0x{}", hex::encode(&hex_value)) | ^^^^^^^^^^ help: change this to: `hex_value` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

the borrowed expression implements the required traits: grovedb/src/operations/proof/util.rs#L297

warning: the borrowed expression implements the required traits --> grovedb/src/operations/proof/util.rs:297:61 | 297 | .unwrap_or_else(|_| format!("0x{}", hex::encode(&hex_value))) | ^^^^^^^^^^ help: change this to: `hex_value` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args

using `write!()` with a format string that ends in a single newline: grovedb/src/operations/proof/util.rs#L93

warning: using `write!()` with a format string that ends in a single newline --> grovedb/src/operations/proof/util.rs:93:9 | 93 | write!(f, " proof: {}\n", hex::encode(self.proof))?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline help: use `writeln!` instead | 93 - write!(f, " proof: {}\n", hex::encode(self.proof))?; 93 + writeln!(f, " proof: {}", hex::encode(self.proof))?; |

using `write!()` with a format string that ends in a single newline: grovedb/src/operations/proof/util.rs#L88

warning: using `write!()` with a format string that ends in a single newline --> grovedb/src/operations/proof/util.rs:88:9 | 88 | / write!( 89 | | f, 90 | | " value: {},\n", 91 | | element_hex_to_ascii(self.value.as_ref()) 92 | | )?; | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline help: use `writeln!` instead | 88 ~ writeln!( 89 | f, 90 ~ " value: {},", |

using `write!()` with a format string that ends in a single newline: grovedb/src/operations/proof/util.rs#L87

warning: using `write!()` with a format string that ends in a single newline --> grovedb/src/operations/proof/util.rs:87:9 | 87 | write!(f, " key: {},\n", hex_to_ascii(&self.key))?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline help: use `writeln!` instead | 87 - write!(f, " key: {},\n", hex_to_ascii(&self.key))?; 87 + writeln!(f, " key: {},", hex_to_ascii(&self.key))?; |

using `write!()` with a format string that ends in a single newline: grovedb/src/operations/proof/util.rs#L78

warning: using `write!()` with a format string that ends in a single newline --> grovedb/src/operations/proof/util.rs:78:9 | 78 | / write!( 79 | | f, 80 | | " path: [{}],\n", 81 | | self.path ... | 85 | | .join(", ") 86 | | )?; | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline help: use `writeln!` instead | 78 ~ writeln!( 79 | f, 80 ~ " path: [{}],", |

using `write!()` with a format string that ends in a single newline: grovedb/src/operations/proof/util.rs#L77

warning: using `write!()` with a format string that ends in a single newline --> grovedb/src/operations/proof/util.rs:77:9 | 77 | write!(f, "ProvedPathKeyValue {{\n")?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline help: use `writeln!` instead | 77 - write!(f, "ProvedPathKeyValue {{\n")?; 77 + writeln!(f, "ProvedPathKeyValue {{")?; |

using `write!()` with a format string that ends in a single newline: grovedb/src/operations/proof/util.rs#L55

warning: using `write!()` with a format string that ends in a single newline --> grovedb/src/operations/proof/util.rs:55:9 | 55 | write!(f, " proof: {}\n", hex::encode(self.proof))?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline help: use `writeln!` instead | 55 - write!(f, " proof: {}\n", hex::encode(self.proof))?; 55 + writeln!(f, " proof: {}", hex::encode(self.proof))?; |

using `write!()` with a format string that ends in a single newline: grovedb/src/operations/proof/util.rs#L50

warning: using `write!()` with a format string that ends in a single newline --> grovedb/src/operations/proof/util.rs:50:9 | 50 | / write!( 51 | | f, 52 | | " value: {},\n", 53 | | optional_element_hex_to_ascii(self.value.as_ref()) 54 | | )?; | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline help: use `writeln!` instead | 50 ~ writeln!( 51 | f, 52 ~ " value: {},", |

using `write!()` with a format string that ends in a single newline: grovedb/src/operations/proof/util.rs#L49

warning: using `write!()` with a format string that ends in a single newline --> grovedb/src/operations/proof/util.rs:49:9 | 49 | write!(f, " key: {},\n", hex_to_ascii(&self.key))?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline help: use `writeln!` instead | 49 - write!(f, " key: {},\n", hex_to_ascii(&self.key))?; 49 + writeln!(f, " key: {},", hex_to_ascii(&self.key))?; |

using `write!()` with a format string that ends in a single newline: grovedb/src/operations/proof/util.rs#L40

warning: using `write!()` with a format string that ends in a single newline --> grovedb/src/operations/proof/util.rs:40:9 | 40 | / write!( 41 | | f, 42 | | " path: [{}],\n", 43 | | self.path ... | 47 | | .join(", ") 48 | | )?; | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline help: use `writeln!` instead | 40 ~ writeln!( 41 | f, 42 ~ " path: [{}],", |

using `write!()` with a format string that ends in a single newline: grovedb/src/operations/proof/util.rs#L39

warning: using `write!()` with a format string that ends in a single newline --> grovedb/src/operations/proof/util.rs:39:9 | 39 | write!(f, "ProvedPathKeyValue {{\n")?; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline = note: `#[warn(clippy::write_with_newline)]` on by default help: use `writeln!` instead | 39 - write!(f, "ProvedPathKeyValue {{\n")?; 39 + writeln!(f, "ProvedPathKeyValue {{")?; |

writing `&Vec` instead of `&[_]` involves a new object where a slice will do: grovedb/src/operations/proof/generate.rs#L371

warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do --> grovedb/src/operations/proof/generate.rs:371:22 | 371 | query_items: &Vec<QueryItem>, | ^^^^^^^^^^^^^^^ help: change this to: `&[QueryItem]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg

called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()`: grovedb/src/operations/proof/generate.rs#L353

warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` --> grovedb/src/operations/proof/generate.rs:353:13 | 353 | overall_limit.as_mut().map(|limit| *limit -= 1); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- | | | help: try: `if let Some(limit) = overall_limit.as_mut() { ... }` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn

deref which would be done by auto-deref: grovedb/src/operations/proof/generate.rs#L348

warning: deref which would be done by auto-deref --> grovedb/src/operations/proof/generate.rs:348:47 | 348 | .map(|a| hex_to_ascii(*a)) | ^^ help: try: `a` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref

called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()`: grovedb/src/operations/proof/generate.rs#L321

warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` --> grovedb/src/operations/proof/generate.rs:321:33 | 321 | ... overall_limit.as_mut().map(|limit| *limit -= 1); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- | | | help: try: `if let Some(limit) = overall_limit.as_mut() { ... }` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn

called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()`: grovedb/src/operations/proof/generate.rs#L270

warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` --> grovedb/src/operations/proof/generate.rs:270:33 | 270 | ... overall_limit.as_mut().map(|limit| *limit -= 1); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- | | | help: try: `if let Some(limit) = overall_limit.as_mut() { ... }` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn

called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()`: grovedb/src/operations/proof/generate.rs#L261

warning: called `map(f)` on an `Option` value where `f` is a closure that returns the unit type `()` --> grovedb/src/operations/proof/generate.rs:261:33 | 261 | ... overall_limit.as_mut().map(|limit| *limit -= 1); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- | | | help: try: `if let Some(limit) = overall_limit.as_mut() { ... }` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn = note: `#[warn(clippy::option_map_unit_fn)]` on by default

deref which would be done by auto-deref: grovedb/src/operations/proof/generate.rs#L202

warning: deref which would be done by auto-deref --> grovedb/src/operations/proof/generate.rs:202:43 | 202 | .map(|a| hex_to_ascii(*a)) | ^^ help: try: `a` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref

deref which would be done by auto-deref: grovedb/src/operations/proof/generate.rs#L173

warning: deref which would be done by auto-deref --> grovedb/src/operations/proof/generate.rs:173:47 | 173 | .map(|a| hex_to_ascii(*a)) | ^^ help: try: `a` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref

redundant closure: grovedb/src/element/mod.rs#L139

warning: redundant closure --> grovedb/src/element/mod.rs:139:53 | 139 | .map_or("None".to_string(), |k| hex::encode(k)), | ^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `hex::encode` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure

redundant closure: grovedb/src/element/mod.rs#L117

warning: redundant closure --> grovedb/src/element/mod.rs:117:53 | 117 | .map_or("None".to_string(), |k| hex::encode(k)), | ^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `hex::encode` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure

this function has too many arguments (11/7): grovedb/src/element/query.rs#L692

warning: this function has too many arguments (11/7) --> grovedb/src/element/query.rs:692:5 | 692 | / fn query_item( 693 | | storage: &RocksDbStorage, 694 | | item: &QueryItem, 695 | | results: &mut Vec<QueryResultElement>, ... | 703 | | add_element_function: fn(PathQueryPushArgs) -> CostResult<(), Error>, 704 | | ) -> CostResult<(), Error> { | |______________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: `#[warn(clippy::too_many_arguments)]` on by default

deref which would be done by auto-deref: grovedb/src/element/query.rs#L212

warning: deref which would be done by auto-deref --> grovedb/src/element/query.rs:212:39 | 212 | .map(|p| hex_to_ascii(*p)) | ^^ help: try: `p` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref = note: `#[warn(clippy::explicit_auto_deref)]` on by default

redundant closure: grovedb/src/element/query.rs#L204

warning: redundant closure --> grovedb/src/element/query.rs:204:49 | 204 | self.key.map_or("None".to_string(), |k| hex_to_ascii(k)) | ^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `hex_to_ascii` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure = note: `#[warn(clippy::redundant_closure)]` on by default

useless use of `format!`: grovedb/src/element/query.rs#L175

warning: useless use of `format!` --> grovedb/src/element/query.rs:175:22 | 175 | let mut output = format!("SubqueryBranch {{\n"); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"SubqueryBranch {\n".to_string()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format = note: `#[warn(clippy::useless_format)]` on by default

this `let...else` may be rewritten with the `?` operator: grovedb/src/element/helpers.rs#L375

warning: this `let...else` may be rewritten with the `?` operator --> grovedb/src/element/helpers.rs:375:9 | 375 | / let Some(value_cost) = self.get_specialized_cost().ok() else { 376 | | return None; 377 | | }; | |__________^ help: replace it with: `let value_cost = self.get_specialized_cost().ok()?;` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark = note: `#[warn(clippy::question_mark)]` on by default

writing `&Vec` instead of `&[_]` involves a new object where a slice will do: grovedb/src/element/helpers.rs#L304

warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do --> grovedb/src/element/helpers.rs:304:14 | 304 | key: &Vec<u8>, | ^^^^^^^^ help: change this to: `&[u8]` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg = note: `#[warn(clippy::ptr_arg)]` on by default

the borrowed expression implements the required traits: grovedb/src/debugger.rs#L30

warning: the borrowed expression implements the required traits --> grovedb/src/debugger.rs:30:34 | 30 | fs::write(&grovedbg_zip, &GROVEDBG_ZIP).expect("cannot crate grovedbg.zip"); | ^^^^^^^^^^^^^ help: change this to: `GROVEDBG_ZIP` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default

usage of `contains_key` followed by `insert` on a `HashMap`: grovedb/src/batch/estimated_costs/average_case_costs.rs#L277

warning: usage of `contains_key` followed by `insert` on a `HashMap` --> grovedb/src/batch/estimated_costs/average_case_costs.rs:277:13 | 277 | / if !self.cached_merks.contains_key(&base_path) { 278 | | GroveDb::add_average_case_get_merk_at_path::<RocksDbStorage>( 279 | | &mut cost, 280 | | &base_path, ... | 287 | | .insert(base_path, estimated_layer_info.is_sum_tree); 288 | | } | |_____________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry = note: `#[warn(clippy::map_entry)]` on by default help: try | 277 ~ self.cached_merks.entry(base_path).or_insert_with(|| { 278 + GroveDb::add_average_case_get_merk_at_path::<RocksDbStorage>( 279 + &mut cost, 280 + &base_path, 281 + estimated_layer_info 282 + .estimated_layer_count 283 + .estimated_to_be_empty(), 284 + estimated_layer_info.is_sum_tree, 285 + ); 286 + estimated_layer_info.is_sum_tree 287 + }); |

unnecessary use of `get(path).is_none()`: grovedb/src/batch/estimated_costs/average_case_costs.rs#L231

warning: unnecessary use of `get(path).is_none()` --> grovedb/src/batch/estimated_costs/average_case_costs.rs:231:30 | 231 | if self.cached_merks.get(path).is_none() { | ------------------^^^^^^^^^^^^^^^^^^^ | | | help: replace it with: `!self.cached_merks.contains_key(path)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check = note: `#[warn(clippy::unnecessary_get_then_check)]` on by default

variants `Execute`, `AverageCase`, and `WorstCase` are never constructed: grovedb/src/batch/mode.rs#L46

warning: variants `Execute`, `AverageCase`, and `WorstCase` are never constructed --> grovedb/src/batch/mode.rs:46:5 | 45 | pub enum BatchRunMode { | ------------ variants in this enum 46 | Execute, | ^^^^^^^ 47 | #[cfg(feature = "estimated_costs")] 48 | AverageCase(HashMap<KeyInfoPath, EstimatedLayerInformation>), | ^^^^^^^^^^^ 49 | #[cfg(feature = "estimated_costs")] 50 | WorstCase(HashMap<KeyInfoPath, WorstCaseLayerInformation>), | ^^^^^^^^^ | = note: `BatchRunMode` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis

method `get_batch_run_mode` is never used: grovedb/src/batch/mod.rs#L686

warning: method `get_batch_run_mode` is never used --> grovedb/src/batch/mod.rs:686:8 | 683 | trait TreeCache<G, SR> { | --------- method in this trait ... 686 | fn get_batch_run_mode(&self) -> BatchRunMode; | ^^^^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default

this `else { if .. }` block can be collapsed: grovedb/src/query/mod.rs#L497

warning: this `else { if .. }` block can be collapsed --> grovedb/src/query/mod.rs:497:16 | 497 | } else { | ________________^ 498 | | if let Some(path) = self.in_path.as_ref() { 499 | | path.as_slice() == key 500 | | } else { 501 | | false 502 | | } 503 | | } | |_________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_else_if = note: `#[warn(clippy::collapsible_else_if)]` on by default help: collapse nested if block | 497 ~ } else if let Some(path) = self.in_path.as_ref() { 498 + path.as_slice() == key 499 + } else { 500 + false 501 + } |

unused import: `net::Ipv4Addr`: grovedb/src/debugger.rs#L3

warning: unused import: `net::Ipv4Addr` --> grovedb/src/debugger.rs:3:15 | 3 | use std::{fs, net::Ipv4Addr, sync::Weak}; | ^^^^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default

duplicated attribute: merk/src/estimated_costs/average_case_costs.rs#L77

warning: duplicated attribute --> merk/src/estimated_costs/average_case_costs.rs:77:7 | 77 | #[cfg(feature = "full")] | ^^^^^^^^^^^^^^^^ | note: first defined here --> merk/src/estimated_costs/average_case_costs.rs:76:7 | 76 | #[cfg(feature = "full")] | ^^^^^^^^^^^^^^^^ help: remove this attribute --> merk/src/estimated_costs/average_case_costs.rs:77:7 | 77 | #[cfg(feature = "full")] | ^^^^^^^^^^^^^^^^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duplicated_attributes = note: `#[warn(clippy::duplicated_attributes)]` on by default

this function has too many arguments (8/7): merk/src/tree/mod.rs#L783

warning: this function has too many arguments (8/7) --> merk/src/tree/mod.rs:783:5 | 783 | / pub fn put_value_with_reference_value_hash_and_value_cost( 784 | | mut self, 785 | | value: Vec<u8>, 786 | | value_hash: CryptoHash, ... | 805 | | >, 806 | | ) -> CostResult<Self, Error> { | |________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

this function has too many arguments (8/7): merk/src/tree/walk/mod.rs#L316

warning: this function has too many arguments (8/7) --> merk/src/tree/walk/mod.rs:316:5 | 316 | / pub fn put_value_with_reference_value_hash_and_value_cost( 317 | | mut self, 318 | | value: Vec<u8>, 319 | | value_hash: CryptoHash, ... | 338 | | >, 339 | | ) -> CostResult<Self, Error> { | |________________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

this function has too many arguments (9/7): merk/src/tree/ops.rs#L690

assigning the result of `Clone::clone()` may be inefficient: merk/src/proofs/query/merge.rs#L385

warning: assigning the result of `Clone::clone()` may be inefficient --> merk/src/proofs/query/merge.rs:385:17 | 385 | / self.default_subquery_branch.subquery = 386 | | other_default_subquery_branch.subquery.clone(); | |__________________________________________________________________^ help: use `clone_from()`: `self.default_subquery_branch.subquery.clone_from(&other_default_subquery_branch.subquery)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones

assigning the result of `Clone::clone()` may be inefficient: merk/src/proofs/query/merge.rs#L336

warning: assigning the result of `Clone::clone()` may be inefficient --> merk/src/proofs/query/merge.rs:336:25 | 336 | / self.default_subquery_branch.subquery = 337 | | other_default_subquery_branch.subquery.clone(); | |__________________________________________________________________________^ help: use `clone_from()`: `self.default_subquery_branch.subquery.clone_from(&other_default_subquery_branch.subquery)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones

assigning the result of `Clone::clone()` may be inefficient: merk/src/proofs/query/merge.rs#L253

warning: assigning the result of `Clone::clone()` may be inefficient --> merk/src/proofs/query/merge.rs:253:13 | 253 | self.default_subquery_branch.subquery = other_default_branch_subquery.clone(); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `self.default_subquery_branch.subquery.clone_from(&other_default_branch_subquery)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones = note: `#[warn(clippy::assigning_clones)]` on by default

module has the same name as its containing module: merk/src/proofs/chunk.rs#L5

warning: module has the same name as its containing module --> merk/src/proofs/chunk.rs:5:1 | 5 | pub mod chunk; | ^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception = note: `#[warn(clippy::module_inception)]` on by default

very complex type used. Consider factoring parts into `type` definitions: merk/src/merk/mod.rs#L578

warning: very complex type used. Consider factoring parts into `type` definitions --> merk/src/merk/mod.rs:578:10 | 578 | ) -> (BTreeMap<Vec<u8>, CryptoHash>, BTreeMap<Vec<u8>, Vec<u8>>) { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity

this function has too many arguments (8/7): merk/src/merk/apply.rs#L277

this function has too many arguments (8/7): merk/src/merk/apply.rs#L176

warning: this function has too many arguments (8/7) --> merk/src/merk/apply.rs:176:5 | 176 | / pub fn apply_with_costs_just_in_time_value_update<KB, KA>( 177 | | &mut self, 178 | | batch: &MerkBatch<KB>, 179 | | aux: &AuxMerkBatch<KA>, ... | 198 | | >, 199 | | ) -> CostResult<(), Error> | |______________________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: `#[warn(clippy::too_many_arguments)]` on by default

very complex type used. Consider factoring parts into `type` definitions: merk/src/merk/chunks.rs#L346

warning: very complex type used. Consider factoring parts into `type` definitions --> merk/src/merk/chunks.rs:346:33 | 346 | fn next_chunk(&mut self) -> Option<Result<(Vec<Op>, Option<Vec<u8>>), Error>> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity = note: `#[warn(clippy::type_complexity)]` on by default

trait `BTreeMapExtras` is never used: merk/src/proofs/query/map.rs#L244

warning: trait `BTreeMapExtras` is never used --> merk/src/proofs/query/map.rs:244:7 | 244 | trait BTreeMapExtras { | ^^^^^^^^^^^^^^

method `attempt_state_recovery` is never used: merk/src/merk/restore.rs#L390

warning: method `attempt_state_recovery` is never used --> merk/src/merk/restore.rs:390:8 | 66 | impl<'db, S: StorageContext<'db>> Restorer<S> { | --------------------------------------------- method in this implementation ... 390 | fn attempt_state_recovery(&mut self) -> Result<(), Error> { | ^^^^^^^^^^^^^^^^^^^^^^ | = note: `#[warn(dead_code)]` on by default

'test' may be misspelled as 'tests': merk/src/tree/fuzz_tests.rs#L3

warning: 'test' may be misspelled as 'tests' --> merk/src/tree/fuzz_tests.rs:3:8 | 3 | #![cfg(tests)] | ^^^^^ help: did you mean: `test` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#maybe_misused_cfg = note: `#[warn(clippy::maybe_misused_cfg)]` on by default

unused import: `ExitStatus`: grovedb/build.rs#L6

warning: unused import: `ExitStatus` --> grovedb/build.rs:6:28 | 6 | process::{Command, ExitStatus, Output}, | ^^^^^^^^^^ | = note: `#[warn(unused_imports)]` on by default

Linting

The following actions uses node12 which is deprecated and will be forced to run on node16: styfle/[email protected], actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

Linting

The following actions uses Node.js version which is deprecated and will be forced to run on node20: styfle/[email protected], actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/

Linting

Tests

Compilation errors

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat!: proof system v1 (from v0.1) #548

Summary

feat!: proof system v1 (from v0.1) #548

Jobs

Run details

grovedb.yml

Annotations