Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: proof panic when proving absent path with intermediary empty tree. #276

Merged
merged 10 commits into from
Oct 26, 2023

Conversation

iammadab
Copy link
Contributor

@iammadab iammadab commented Oct 26, 2023

Encountered a panic in proof when you try to something in an non-existent subtree, when the non-existent subtree would have been in an empty tree (very very very rare case).
This pr prevents panics from happening along that path and fixes the error by returning the empty tree op

Issue being fixed or feature implemented

What was done?

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@iammadab iammadab marked this pull request as ready for review October 26, 2023 13:52
@QuantumExplorer QuantumExplorer merged commit 1119847 into develop Oct 26, 2023
7 checks passed
@QuantumExplorer QuantumExplorer deleted the feat/empty-tree-path-bug branch October 26, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants