Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: chunk ids as vec bytes #294

Merged
merged 5 commits into from
May 8, 2024
Merged

Conversation

ogabrielides
Copy link
Collaborator

@ogabrielides ogabrielides commented May 2, 2024

Issue being fixed or feature implemented

Merk chunking code was using internally string to identify chunks by their traversal instructions: "1" for left and "0" for right.

What was done?

This PR changes this to Vec<u8>.
In a future PR, we can compact traversal instructions into bitvec.

How Has This Been Tested?

All chunk unit tests were updated.

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@ogabrielides ogabrielides changed the title Feat: chunk ids as vec bytes feat: chunk ids as vec bytes May 2, 2024
@ogabrielides ogabrielides merged commit cda80d5 into develop May 8, 2024
7 checks passed
@ogabrielides ogabrielides deleted the feat/chunk-ids-as-bytes branch May 8, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants