Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: correct constructors for SubtreeStateSyncInfo and MultiStateSyncInfo #298

Merged
merged 5 commits into from
May 16, 2024

Conversation

ogabrielides
Copy link
Collaborator

@ogabrielides ogabrielides commented May 15, 2024

Issue being fixed or feature implemented

Constructors for SubtreeStateSyncInfo and MultiStateSyncInfo were depended on a ref of grovedb.

What was done?

Simplified this by using default new() approach

How Has This Been Tested?

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

grovedb/src/replication.rs Outdated Show resolved Hide resolved
@ogabrielides ogabrielides merged commit 016795e into develop May 16, 2024
7 checks passed
@ogabrielides ogabrielides deleted the refactor/correct-constructors branch May 16, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants