Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reference insertion without batch + verify #327

Merged
merged 4 commits into from
Aug 14, 2024

Conversation

fominok
Copy link
Collaborator

@fominok fominok commented Aug 14, 2024

Issue being fixed or feature implemented

This PR addresses an issue with references insertion outside of a batch, also fixes verify function to align it all with batches and proof system

What was done?

Combined hash of references now uses value hash of the last item of references chain instead of the value hash of the direct item, which in turn could be a reference

How Has This Been Tested?

add tests for longer reference chains both for batch insertions and regular ones

Breaking Changes

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@QuantumExplorer
Copy link
Member

Great!

@QuantumExplorer QuantumExplorer merged commit a054032 into develop Aug 14, 2024
7 checks passed
@QuantumExplorer QuantumExplorer deleted the grovedbg-verify-with-references-more-tests branch August 14, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants