-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: drop python 3.8 #569
chore: drop python 3.8 #569
Conversation
Should add 3.13 at the same time |
(need the same at dask-histogram too, but all CI is red right now) |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #569 +/- ##
==========================================
- Coverage 93.06% 91.98% -1.09%
==========================================
Files 23 22 -1
Lines 3290 3542 +252
==========================================
+ Hits 3062 3258 +196
- Misses 228 284 +56 ☔ View full report in Codecov by Sentry. |
conda tests will fail until dask histogram is updated in conda. |
ok - looks like we're good to go. Need to check something over in uproot though. |
Nope - right - uproot is OK because the tree reduction for the reports is here. Very good. |
any objections about merging this PR @martindurant and @lgray ? |
I hope I haven't forgotten any places?