Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop python 3.8 #569

Merged
merged 5 commits into from
Feb 10, 2025

Conversation

pfackeldey
Copy link
Collaborator

I hope I haven't forgotten any places?

@martindurant
Copy link
Collaborator

Should add 3.13 at the same time

@martindurant
Copy link
Collaborator

(need the same at dask-histogram too, but all CI is red right now)

@pfackeldey pfackeldey marked this pull request as ready for review February 7, 2025 18:46
@lgray lgray closed this Feb 8, 2025
@lgray lgray reopened this Feb 8, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 8, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.98%. Comparing base (8cb8994) to head (12049c8).
Report is 213 commits behind head on main.

Files with missing lines Patch % Lines
src/dask_awkward/lib/io/io.py 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #569      +/-   ##
==========================================
- Coverage   93.06%   91.98%   -1.09%     
==========================================
  Files          23       22       -1     
  Lines        3290     3542     +252     
==========================================
+ Hits         3062     3258     +196     
- Misses        228      284      +56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lgray
Copy link
Collaborator

lgray commented Feb 8, 2025

conda tests will fail until dask histogram is updated in conda.

@lgray lgray closed this Feb 9, 2025
@lgray lgray reopened this Feb 9, 2025
@lgray lgray closed this Feb 9, 2025
@lgray lgray reopened this Feb 9, 2025
@lgray
Copy link
Collaborator

lgray commented Feb 9, 2025

ok - looks like we're good to go. Need to check something over in uproot though.

@lgray
Copy link
Collaborator

lgray commented Feb 9, 2025

Nope - right - uproot is OK because the tree reduction for the reports is here. Very good.

@pfackeldey
Copy link
Collaborator Author

any objections about merging this PR @martindurant and @lgray ?

@martindurant martindurant merged commit ce1b71d into dask-contrib:main Feb 10, 2025
62 of 68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants